Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Preload media REST API request #3197

Closed
spacedmonkey opened this issue Jul 14, 2020 · 1 comment · Fixed by #3196
Closed

Editor: Preload media REST API request #3197

spacedmonkey opened this issue Jul 14, 2020 · 1 comment · Fixed by #3196
Assignees
@spacedmonkey
Labels
Group: Media Type: Enhancement New feature or improvement of an existing feature

Comments

@spacedmonkey
Copy link
Contributor

spacedmonkey commented Jul 14, 2020 •
edited by swissspidy
Loading

Feature Description

Similar to what was done in #2933, we can leverage the same _web_stories_envelope technique to markedly improve perceived performance when opening the editor by preloading requests to the Media REST API endpoint.

Alternatives Considered

Additional Context

Eventually this will be fixed in @wordpress/api-fetch so that we don't have to maintain this _web_stories_envelope logic ourselves anymore. See WordPress/gutenberg#23807

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

  • When opening the editor, now extra HTTP request is made for the Media Library, as the request is preloaded upon page load.

Implementation Brief
@spacedmonkey spacedmonkey added Type: Enhancement New feature or improvement of an existing feature Group: Media Pod: WP & Infra labels Jul 14, 2020
@spacedmonkey spacedmonkey mentioned this issue Jul 14, 2020
Merged
@swissspidy swissspidy mentioned this issue Jul 14, 2020
Closed
@swissspidy swissspidy added this to the Sprint 33 milestone Jul 14, 2020
@swissspidy swissspidy changed the title Preload Media REST API requests Editor: Preload media REST API request Jul 14, 2020
@spacedmonkey
Copy link
Contributor Author

Update: WordPress/gutenberg#23807 has been merged

@spacedmonkey spacedmonkey mentioned this issue Aug 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spacedmonkey spacedmonkey

Labels
Group: Media Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Performance: Preload media REST API request in editor GoogleForCreators/web-stories-wp
2 participants
@spacedmonkey @swissspidy