Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Tests: Use waitForSelector to wait for sidebar presence #21180

Merged
merged 1 commit into from
Mar 26, 2020
Merged

E2E Tests: Use waitForSelector to wait for sidebar presence #21180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/e2e-tests/specs/editor/various/sidebar.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,7 @@ describe( 'Sidebar', () => {

await setBrowserViewport( 'large' );

const sidebarsDesktop = await page.$$( SIDEBAR_SELECTOR );
expect( sidebarsDesktop ).toHaveLength( 1 );
await page.waitForSelector( SIDEBAR_SELECTOR );
} );

it( 'should preserve tab order while changing active tab', async () => {
Expand Down