E2E Tests: Use waitForSelector to wait for sidebar presence #21180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 856 kB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21177
This pull request seeks to resolve an intermittent end-to-end test failure in the Sidebar tests. See #21177 for the full message and initial debugging information. The changes here seek to resolve this by leveraging
waitForSelectorto allow for a delay in the presence of the sidebar which is expected to be shown. It's assumed this will resolve the issue because, as observed by notes in #21177, there appears to be a CPU-bound race condition between the browser resizing and the sidebar showing. While these sorts of delays are not ideal, the use ofwaitForSelectorwill prove to be more durable in any case.Testing Instructions:
Ensure end-to-end tests pass: