Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@wordpress/env: Fix accidental quotes in Site Title #20520

Merged
merged 1 commit into from
Mar 2, 2020
Merged

@wordpress/env: Fix accidental quotes in Site Title #20520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions packages/env/lib/env.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,13 +411,17 @@ async function configureWordPress( environment, config ) {
// Install WordPress.
await dockerCompose.run(
environment === 'development' ? 'cli' : 'tests-cli',
`wp core install
--url=localhost:${ port }
--title='${ config.name }'
--admin_user=admin
--admin_password=password
--admin_email=wordpress@example.com
--skip-email`,
[
'wp',
'core',
'install',
`--url=localhost:${ port }`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated: I have a use-case I'm wondering if there is some better support for, or if we could make better support for. Specifically, to test Internet Explorer, I use VirtualBox and a Microsoft-provided VM. To test the Gutenberg site from the host machine, I find that I have to go to Settings > General and change the url from localhost to the IP address of my host machine on my local network (192.168.1.162). If we have configurations for other values (like port), is it something where we could allow configuration of the hostname here as well? Would that work as well as I'm expecting it to, if I would have a .wp-env.override.json in my local Gutenberg directory?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, interesting. Yes we could add siteURL to .wp-env.json and then you would set it in .wp-env.override.json for this use case. I'm not sure if it's worth adding this functionality though given that the URL can be changed easily via WP Admin.

@tellthemachines: I remember you running into this. What did you end up doing? Do you map localhost in VirtualBox to the host machine's IP?

`--title=${ config.name }`,
'--admin_user=admin',
'--admin_password=password',
'--admin_email=wordpress@example.com',
'--skip-email',
],
options
);

Expand Down