@wordpress/env: Fix accidental quotes in Site Title #20520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 866 kB ℹ️ View Unchanged
|
aduth
reviewed
Feb 28, 2020
| 'wp', | ||
| 'core', | ||
| 'install', | ||
| `--url=localhost:${ port }`, |
There was a problem hiding this comment.
Unrelated: I have a use-case I'm wondering if there is some better support for, or if we could make better support for. Specifically, to test Internet Explorer, I use VirtualBox and a Microsoft-provided VM. To test the Gutenberg site from the host machine, I find that I have to go to Settings > General and change the url from localhost to the IP address of my host machine on my local network (192.168.1.162). If we have configurations for other values (like port), is it something where we could allow configuration of the hostname here as well? Would that work as well as I'm expecting it to, if I would have a .wp-env.override.json in my local Gutenberg directory?
There was a problem hiding this comment.
Hm, interesting. Yes we could add siteURL to .wp-env.json and then you would set it in .wp-env.override.json for this use case. I'm not sure if it's worth adding this functionality though given that the URL can be changed easily via WP Admin.
@tellthemachines: I remember you running into this. What did you end up doing? Do you map localhost in VirtualBox to the host machine's IP?
draganescu
approved these changes
Feb 28, 2020
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 2, 2020
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20002 (comment).
Removes the
's fromwp core installas these were being interpreted literally meaning that the Site Title would be set to'gutenberg'instead ofgutenberg.The fix still accounts for titles which contain spaces by passing an explicit array of arguments to
dockerCompose.run().