Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the top margin and border for the first item in the keyboard shortcuts modal #18358

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

mapk
Copy link
Contributor

@mapk mapk commented Nov 7, 2019

Description

The first item in the keyboard shortcuts was still showing its border and looked funky. I've basically pushed the item up so that the border doesn't show anymore. Fixes #17588

Before:

68354301-db3ab500-00c0-11ea-98b1-5858063c67ed

After:

Screen Shot 2019-11-06 at 6 38 31 PM

How has this been tested?

Locally on FF and Chrome.

Types of changes

CSS non-breaking changes.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@mapk mapk added the General Interface Parts of the UI which don't fall neatly under other labels. label Nov 7, 2019
@mapk mapk requested a review from talldan as a code owner November 7, 2019 02:40
@mapk mapk self-assigned this Nov 7, 2019
@mapk mapk requested a review from jorgefilipecosta November 8, 2019 02:09
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 but I personally wonder if this shortcut should be just included in one of the sections like "Global shortcuts"

@mapk mapk merged commit 5c0123a into master Nov 12, 2019
@mapk mapk deleted the update/keyboard-shortcut-first-item branch November 12, 2019 16:46
@mapk
Copy link
Contributor Author

mapk commented Nov 12, 2019

personally wonder if this shortcut should be just included in one of the sections like "Global shortcuts"

That's where it used to be. There was a desire to move it out for more visibility though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add spacing or remove top line on keyboard shortcuts
2 participants