Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spacing or remove top line on keyboard shortcuts #17588

Closed
karmatosed opened this issue Sep 25, 2019 · 6 comments · Fixed by #18358
Closed

Add spacing or remove top line on keyboard shortcuts #17588

karmatosed opened this issue Sep 25, 2019 · 6 comments · Fixed by #18358
Assignees
@mapk
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress

Comments

@karmatosed
Copy link
Member

Currently, the top line is very close to the top section:

image

I would recommend adding spacing or removing the top line.
@karmatosed karmatosed added the Needs Design Feedback Needs general design feedback. label Sep 26, 2019
@mapk
Copy link
Contributor

mapk commented Oct 1, 2019

I agree here. The initial mockups hid this quite well. In fact, I believe the PR did too at one point. Maybe something changed causing it to drop down again and show the top border? Let's definitely clean this up. 👍

@mapk mapk added Needs Dev Ready for, and needs developer efforts General Interface Parts of the UI which don't fall neatly under other labels. and removed Needs Design Feedback Needs general design feedback. labels Oct 1, 2019
@JuanVqz
Copy link

JuanVqz commented Oct 31, 2019

Hi! I didn't see the mistake anymore.

If is ok, maybe you could close the issue.
Regards

image

@mapk
Copy link
Contributor

mapk commented Nov 7, 2019

The problem still exists. I'll try to knock this out soon.

Screen Shot 2019-11-06 at 6 11 12 PM

@JuanVqz
Copy link

JuanVqz commented Nov 7, 2019

I could help but I didn’t see, what is the file? When selecting a block it shows?

@mapk mapk mentioned this issue Nov 7, 2019
Merged
5 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 7, 2019
@mapk
Copy link
Contributor

mapk commented Nov 7, 2019

@JuanVqz, which version of Gutenberg are you using? It looks like the keyboard shortcut panel reveals it might be an older version? Do you have the Gutenberg plugin installed and updated?

@JuanVqz
Copy link

JuanVqz commented Nov 7, 2019

Right now I don’t know what version I have but I think is a new version because I downloaded recently. (Like 6 days ago)
tomorrow I could share my version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapk mapk

Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
3 participants
@karmatosed @mapk @JuanVqz