Update Dashicons.

[jasmussen]

This removes the title element from the sprite. This should finally fix #528.

Corresponding upstream PR: WordPress/dashicons#192

[jasmussen]

It looks like the tests fail for the icon unit test. Is that test written to look for the title? @BE-Webdesign I think you may have done some of the magic here, can you provide me with a sanity check (not urgent)? I know I made a mistake upstream that I'm fixing, but I'm not sure what's up here. Thank you.

[BE-Webdesign]

@jasmussen,

Okay I read over #528, are we supposed to add an aria-label instead? The tests indeed check for the title for accessibility, so they are failing now due to the missing title tag. If you need help let me know I can either fix it for you or show you how to change the tests.

[jasmussen]

Okay I read over #528, are we supposed to add an aria-label instead? T

My reading is that whatever label we add should be in a parent containing element:

<button aria-label="Some label here"><SVG here></button>

CC: @afercia

[afercia]

Yes when the icon is not purely decorative and represents content that needs to be announced, then this content can be provided as aria-label on the containing element or, as mentioned in #528, using the Twenty Seventeen approach with screen-reader-text e.g.:

<button type="submit" class="search-submit">
	<svg class="icon icon-search" aria-hidden="true" role="img">
		<use href="#icon-search" xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="#icon-search"></use>
	</svg>
	<span class="screen-reader-text">Search</span>
</button>

Either way, the title should be removed.

I forgot to clarify that SVGs should also have aria-hidden="true" role="img", sorry for being unclear.

[BE-Webdesign]

My reading is that whatever label we add should be in a parent containing element: <button aria-label="Some label here"><SVG here></button>

You have much better eyesight than me 😲

[BE-Webdesign]

If you need any assistance with the tests let me know, happy to help.

[aduth]

Fixed failing test in 9b21b6f. Up to you if you'd like to merge as-is and address @afercia's comment in a subsequent pull request:

I forgot to clarify that SVGs should also have aria-hidden="true" role="img", sorry for being unclear.

[jasmussen]

Thanks! Merging this and putting in an upstream fix again.