This repository has been archived by the owner on Jan 26, 2023. It is now read-only.
Add aria-hidden and role attributes to react component #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses an accessibility issue with the react component, by adding attributes aria-hidden="true" and role="img" to the component. See also discussion in WordPress/gutenberg#1012 (review).
jasmussen
added a commit
to WordPress/gutenberg
that referenced
this pull request
Jun 6, 2017
This PR adds aria-hidden="true" and role="img" to the SVG files inside the dashicons component, addressing feedback here: #1012 (comment) Upstream PR: WordPress/dashicons#194 CC: @afercia
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an accessibility issue with the react component, by adding attributes aria-hidden="true" and role="img" to the component.
See also discussion in WordPress/gutenberg#1012 (review).