Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.5.0 #310

Merged
merged 23 commits into from
Mar 27, 2023
Merged

Version 2.5.0 #310

merged 23 commits into from
Mar 27, 2023

Conversation

tw2113
Copy link
Member

@tw2113 tw2113 commented Mar 16, 2023

No description provided.

tw2113 and others added 23 commits March 16, 2023 08:53
* we accept 4 params but pass 3. Just aligning details

* add term meta watching ability with empty default

* add user meta watching ability with empty default

* update version number from NEXT
* touch up range input based on more recent version of Algolia CSS

* more general updates to our CSS. Covers the rest of what is being found as included for default templates
* load new class files for menu sections

* instantiate our new admin pages

* new partials that show our "blurred out" settings

* update references from premium to pro

* add "(Pro)" wording to admin menu items.

* linting PHPDoc complaint fixing
* update screenshot list

* update screenshots
* update version and add action hook to hit template

* add autocomplete template hook

* rename the instantsearch hook name

* update autocomplete template version number

* underscores instead of dashes, fix prefix to match elsewhere in the plugin
* new footer link

* missed some textdomains

* make bold

* revise menu display to have some markup we can style

* touch of style for "pro"

* new menu item and redirect handling

* borrow from AIOSEO for highlighting submenus and some link target

* style up our submenu items a bit

* add consistency to all translators comments, fix linting and missing nonces

* add in some phpcs ignore spots for two valid spots

---------

Co-authored-by: Scott Basgaard <sbasgaard@gmail.com>
* give our new URL a slightly more unique GET parameter for better strpos targeting

* fix typo in phpcs rule

---------

Co-authored-by: Scott Basgaard <sbasgaard@gmail.com>
* update headings to be not quite so overly descriptive

* new helper function for checking for Algolia Pro
* add Scott as a contributor

* draft new FAQ regarding Algolia Pro

* remove Algolia/WDS about questions

* some extra line breaks, and Pro messaging
* fix undefined index warnings

* return early but without registering a new menu page

* misc array shorthand
* initial CTA with largely empty details

* new utility static cta method

* make use of utility method instead of hardcoding in both screens

* tell to ignore escaping in these spots

* phpdoc and misc spacing
@tw2113 tw2113 requested a review from scottbasgaard March 27, 2023 15:45
@tw2113 tw2113 marked this pull request as ready for review March 27, 2023 15:45
Copy link
Contributor

@scottbasgaard scottbasgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tw2113 🚀

@tw2113 tw2113 merged commit 8df42fb into main Mar 27, 2023
@tw2113 tw2113 deleted the release250 branch March 27, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants