Feature/178 pro settings #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tw2113 not sure if this is still a WIP but guess this doesn't pass because of:
Will let you fix so I don't clutter with lint commits 😄 |
scottbasgaard
suggested changes
Mar 16, 2023
tw2113
added a commit
that referenced
this pull request
Mar 27, 2023
* pass indices to filter for better watcher customization (#270) * provide a filter for our locate template method to provide a custom server path to templates (#269) * fresh update of our icon branch (#302) * Feature/243 term user meta watching (#272) * we accept 4 params but pass 3. Just aligning details * add term meta watching ability with empty default * add user meta watching ability with empty default * update version number from NEXT * update and clarify Autocomplete settings (#307) * Update and confirm extra styles we ship with out of box. (#309) * touch up range input based on more recent version of Algolia CSS * more general updates to our CSS. Covers the rest of what is being found as included for default templates * Feature/178 pro settings (#303) * load new class files for menu sections * instantiate our new admin pages * new partials that show our "blurred out" settings * update references from premium to pro * add "(Pro)" wording to admin menu items. * linting PHPDoc complaint fixing * Feature/224 screenshot updates (#308) * update screenshot list * update screenshots * update version and add action hook to hit template (#305) * update version and add action hook to hit template * add autocomplete template hook * rename the instantsearch hook name * update autocomplete template version number * underscores instead of dashes, fix prefix to match elsewhere in the plugin * bump version number and tested up to version * update current changelog * trim down legacy changelog * Revert "trim down legacy changelog" This reverts commit 63d93a3. * changelog bullet point alignment * bump version number * Feature/239 footer link (#311) * new footer link * missed some textdomains * make bold * revise menu display to have some markup we can style * touch of style for "pro" * new menu item and redirect handling * borrow from AIOSEO for highlighting submenus and some link target * style up our submenu items a bit * add consistency to all translators comments, fix linting and missing nonces * add in some phpcs ignore spots for two valid spots --------- Co-authored-by: Scott Basgaard <sbasgaard@gmail.com> * Fix/update upgrade url (#313) * give our new URL a slightly more unique GET parameter for better strpos targeting * fix typo in phpcs rule --------- Co-authored-by: Scott Basgaard <sbasgaard@gmail.com> * Fix/242 updated settings page headers (#312) * update headings to be not quite so overly descriptive * new helper function for checking for Algolia Pro * Feature/245 readme updates (#314) * add Scott as a contributor * draft new FAQ regarding Algolia Pro * remove Algolia/WDS about questions * some extra line breaks, and Pro messaging * Misc bug fixes (#316) * fix undefined index warnings * return early but without registering a new menu page * misc array shorthand * Feature/238 pro ctas (#315) * initial CTA with largely empty details * new utility static cta method * make use of utility method instead of hardcoding in both screens * tell to ignore escaping in these spots * phpdoc and misc spacing * old screenshots already * update readme screenshot list --------- Co-authored-by: Scott Basgaard <sbasgaard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.