Feature/#434 social links menu #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hidden text (still screen reader accessible)
ImBigWill
reviewed
Jan 18, 2019
commit 1eae31f Author: Corey M Collins <coreymcollins@gmail.com> Date: Fri Jan 18 13:51:15 2019 -0600 Feature/#429 replace hidden elements (#454) * Removes the CSS hiding aside post format post titles * Adds screen reader class if the post is an aside * Actually, just remove the whole screen reader thing * Compiles styles
commit 1eae31f Author: Corey M Collins <coreymcollins@gmail.com> Date: Fri Jan 18 13:51:15 2019 -0600 Feature/#429 replace hidden elements (#454) * Removes the CSS hiding aside post format post titles * Adds screen reader class if the post is an aside * Actually, just remove the whole screen reader thing * Compiles styles
|
I think we should be set with Thanks! |
ImBigWill
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #434
DESCRIPTION
Adds CSS to replace text with background images in a menu using social network links.
This hides the text but still keeps it accessible to a screen reader so a user will know what they're clicking on.
Additional styles would need to be added to the theme to display the menu items inline, but this takes care of the core functionality and the theme-specific styling can be taken care of as needed with opinionated styles.
SCREENSHOTS
OTHER
STEPS TO VERIFY
wd_s)DOCUMENTATION
Will this pull request require updating the wd_s wiki?
Yes! Once merged in, we'll want to add some documentation around usage and output.