-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social Media Widget #434
Comments
We have added some support for social networks in a couple of themes in the past when social links are needed in a menu-type situation. I haven't had to do it consistently, so it was never added to Basically, we loop through our social networks set in a
Would something like that suffice? Or do you think we still need an actual sidebar widget? |
(this is obviously a bit of an older example with that pesky |
@coreymcollins We should keep our theme clean from widgets and shortcodes (even the yearly shortcode) and create a helper plugin or plugins for this functionality. This will keep code base leaner and easier to maintain. |
@mharis this example doesn't create a widget at all – just basic styles to style links with social network URLs in a menu. This functionality would/does work based on the core WP nav menu without any additional functionality in the theme. Since it's all CSS-based and affects visuals without added widgets/functions, I think this could be pretty easily added to the theme. For me, it seems like overkill to create a plugin for 11 lines of Sass. Thoughts? |
Ohh okay, yes, that makes sense. My original proposal was to create a WP widget. |
With fields, and all the fun stuff which is overkill for a theme, esp a starter theme. |
@mharis still something you think is needed or worth building? |
* Adds styles to replace social icon links in a menu with the icons and hidden text (still screen reader accessible) * Compiles * Squashed commit of the following: commit 1eae31f Author: Corey M Collins <coreymcollins@gmail.com> Date: Fri Jan 18 13:51:15 2019 -0600 Feature/#429 replace hidden elements (#454) * Removes the CSS hiding aside post format post titles * Adds screen reader class if the post is an aside * Actually, just remove the whole screen reader thing * Compiles styles * Compiles styles * Squashed commit of the following: commit 1eae31f Author: Corey M Collins <coreymcollins@gmail.com> Date: Fri Jan 18 13:51:15 2019 -0600 Feature/#429 replace hidden elements (#454) * Removes the CSS hiding aside post format post titles * Adds screen reader class if the post is an aside * Actually, just remove the whole screen reader thing * Compiles styles
We should add a social media wordpress widget or support to add social media/icons to WP menu links.
The text was updated successfully, but these errors were encountered: