Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes some default customizer fields we never use on projects #377

Merged
merged 1 commit into from
Aug 31, 2018

Conversation

coreymcollins
Copy link
Contributor

@coreymcollins coreymcollins commented Aug 28, 2018

DESCRIPTION

Removes some sections and panels from the Customizer that we generally don't use.

During training, I always run through the Customizer but always gloss over a lot of the existing/default Customizer sections with "you can do this here, but it's not the best."

I don't think I've ever known anybody to manage menus or widgets via the Customizer.

For the most part, we don't use a lot of the Customizer features or settings and having so many of them by default just creates confusion for the user. We tend to stick to Site Options and Site Identity, and I can't recall a time where we used Color, Background Image, or (gasp) Additional CSS.

Of course, these could always be added back on a per-project basis by removing the line commenting them out.

SCREENSHOTS

Before:

After:

OTHER

  • Is this issue accessible? (Section 508/WCAG 2.0AA)
  • Does this issue pass all the linting? (PHPCS, ESLint, SassLint)
  • Does this pass CBT?

STEPS TO VERIFY

Checkout the branch and open up the customizer.

Copy link
Contributor

@gregrickaby gregrickaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks! 👍

@gregrickaby gregrickaby merged commit 0fe8c62 into master Aug 31, 2018
@gregrickaby gregrickaby deleted the theme/customizer-cleanup branch August 31, 2018 13:37
gregrickaby added a commit that referenced this pull request Aug 31, 2018
commit 0fe8c62
Author: Corey M Collins <coreymcollins@gmail.com>
Date:   Fri Aug 31 08:37:35 2018 -0500

    Removes some default customizer fields we never use on projects (#377)

commit 7434d33
Author: Zachary Russell <zach@protechig.com>
Date:   Tue Jun 12 08:14:47 2018 -0400

    add gitlab ci integration (#375)

    closes #371
gregrickaby added a commit that referenced this pull request Sep 18, 2018
* update testing url and debounce

* https for local url

* bump

* bump

* update hero block

* add animation class to hero content

* slick bump to 1.8.1

* rename hero-carousel to carousel.js

* version bump

* add carousel markup

* add carousel styles

* increase hero height

* compile ♻️

* bump

* seperate carousel from hero. additional tweaks.

* add support for webm video

* add edge and safari classes. move mobile up

* target .ie & .edge for video-as-background

* compile ♻

* mention acf content blocks

* Squashed commit of the following:

commit 0fe8c62
Author: Corey M Collins <coreymcollins@gmail.com>
Date:   Fri Aug 31 08:37:35 2018 -0500

    Removes some default customizer fields we never use on projects (#377)

commit 7434d33
Author: Zachary Russell <zach@protechig.com>
Date:   Tue Jun 12 08:14:47 2018 -0400

    add gitlab ci integration (#375)

    closes #371

* fix expired slide bug

* remove bottom margin

* enable dots and nav buttons

* style the navigation and dots

* remove adaptive height

* remove min-height, declare height

* convert <button> to <a>

* compile

* Carousel arrow positoning fix

* Center align the carousel pagination dots

* Carousel & Hero Block: Check for button text and URL

* Compiled CSS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants