Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitLab CI Integration #375

Merged
merged 1 commit into from
Jun 12, 2018

Conversation

zachary-russell
Copy link
Contributor

DESCRIPTION

I added support for GitLab CI to wd_s. I created a Docker Image - GitHub Source that does the following:

  • Installs PHP & relevant extensions (PHP 7.2-fpm)
  • Installs composer
  • Installs Web Dev Studios coding standards
  • Installs Node
  • Installs eslint and sass-lint

The .gitlab-ci.yml file then just does the bare minimum it has to -
I'm using Alpine linux to reduce binary size and get it up and running as quickly as possible. In my tests it takes < 1 minute to run the entire linting suite :)

STEPS TO VERIFY

Launch a version of this theme on GitLab and every commit will be ran through the CI pipeline.

DOCUMENTATION

This doesn't actually need any documentation, GitLab CI will run as long as the .gitlab-ci.yml file is present. I'm only linting on the latest version of PHP for the time being. You could set up auto syncing from GitHub to GitLab for this repo to demonstrate functionality.

@gregrickaby gregrickaby self-requested a review June 12, 2018 12:14
Copy link
Contributor

@gregrickaby gregrickaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks! 👍

@gregrickaby gregrickaby merged commit 7434d33 into WebDevStudios:master Jun 12, 2018
gregrickaby added a commit that referenced this pull request Aug 31, 2018
commit 0fe8c62
Author: Corey M Collins <coreymcollins@gmail.com>
Date:   Fri Aug 31 08:37:35 2018 -0500

    Removes some default customizer fields we never use on projects (#377)

commit 7434d33
Author: Zachary Russell <zach@protechig.com>
Date:   Tue Jun 12 08:14:47 2018 -0400

    add gitlab ci integration (#375)

    closes #371
gregrickaby added a commit that referenced this pull request Sep 18, 2018
* update testing url and debounce

* https for local url

* bump

* bump

* update hero block

* add animation class to hero content

* slick bump to 1.8.1

* rename hero-carousel to carousel.js

* version bump

* add carousel markup

* add carousel styles

* increase hero height

* compile ♻️

* bump

* seperate carousel from hero. additional tweaks.

* add support for webm video

* add edge and safari classes. move mobile up

* target .ie & .edge for video-as-background

* compile ♻

* mention acf content blocks

* Squashed commit of the following:

commit 0fe8c62
Author: Corey M Collins <coreymcollins@gmail.com>
Date:   Fri Aug 31 08:37:35 2018 -0500

    Removes some default customizer fields we never use on projects (#377)

commit 7434d33
Author: Zachary Russell <zach@protechig.com>
Date:   Tue Jun 12 08:14:47 2018 -0400

    add gitlab ci integration (#375)

    closes #371

* fix expired slide bug

* remove bottom margin

* enable dots and nav buttons

* style the navigation and dots

* remove adaptive height

* remove min-height, declare height

* convert <button> to <a>

* compile

* Carousel arrow positoning fix

* Center align the carousel pagination dots

* Carousel & Hero Block: Check for button text and URL

* Compiled CSS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants