Feature/#275 use more semantic containers #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to blow up the sidebar in our regular page template 😄
…eader / footer by default
gregrickaby
pushed a commit
that referenced
this pull request
Jul 21, 2017
* Updates .wrap to use $max-width * Removes omega reset mixin Neat 2.0.0 no longer uses right-margin, which is why this mixin was useful in the first place * Moves units of measure from mixins to functions directory This is now called earlier in our main style.scss file, and can be used for calculations within the variables file * Remoces $base-context declaration from typography, and adds it to units-of-measure * Updates breakpoints to use em, and aligns with internal coding standards * Removes phone-portrait map, which was only a 1px query 😬 * Adds a get-gutter function for getting the gutter out of a custom grid Sass map * Adds Sassdoc annotations * Adds the grids classes mixin * Adds a media mixin to aid in writing media queries * Adds super-basic scaffolding for a grid system * compiled styles * Sets up partial for colors mixin * Adds colors mixin * Adds $theme-colors Sass map * Adds colors partial for creating our color presentational classes * compiled styles * Adds color as a param for SVG function * Updates svg function to use display terminology * Adds Sassdoc as npm dependency * Adds Sassdoc gulp task * Initial run of Sassdoc 🎉 * Fixes doc comments * Removes Sassdoc-esque comment * Adds basic description to reverse list function * Updates index.html for Sassdoc * Adds Sassdoc comment * Removes extra poster comment for Sassdoc * Updates gutter function and adds better Sass docs * Updates gutter function * Moves em function into its own file * Moves rem function into its own partial * Moves line-height function to its own partial * Updates units of measure to strip-units * Adds separate base-context partial * Moves reverse list function to functions directory * Adds full Sassdoc to vertical align * Removes vendor prefixes (no longer required per caniuse & internal browser requirements) * Updates param line in Sassdoc * Adds sassdocs to media mixin * compiled styles & sassdoc * Adds Sassdoc block * Updates global media breakpoints (#307); fixes #229 * adds new breakpoints and updates documentation * updates grid settings to utilize the new breakpoints — removes now unused breakpoints * Update breakpoint variables (#309) * adds new breakpoints and updates documentation * updates grid settings to utilize the new breakpoints — removes now unused breakpoints * Replace breakpoint variables (adds -up suffix where applicable) from breakpoint/grid updates so compiles don't break. * Feature/#272 use px on all grid items (#316) * Updates media query breakpoints to use pixels This also removes the -up from the variable name to keep with current convention * Updates variable names throughout theme * Updates media query to remove 1px if a breakpoint variable is used * compiled styles * Feature/#275 use more semantic containers (#317) * Updates grid partial name * Adds full width mixin * Adds content width variable * Adds more helpful comments * Adds better column classes and full width class * Removes full-width class from media partial * Adds a page template that contains sidebar This allows us to blow up the sidebar in our regular page template 😄 * Removes sidebar from standard page template 💥 * Fixes template name * Removes wrap class styles & adds padding to primary & secondary * Adds new column classes * Removes primary / secondary styles in favor of using column classes * Removes all the wraps 👋 💥 * Adds new semantic grid classes to ACF content blocks * Adds has-sidebar to single posts by default * Removes extra padding declarations & adds primary styling when sidebar is present * Removes left / right padding so comments are aligned with content & header / footer by default * Updates Sassdoc * compiled styles * Theme/#314 remove em move back to px and rem (#318) * Removes em and reverts back to rem Some of the updates ensure things like borders meet our internal guidelines (px) * Removes custom grids I've never seen these used, and they're easy enough to spin up * Adds a transitions partial to standardize our transitions * Updates partials to use transition variables * Updates border radii to use the $border-radius variables * compiled styles * Updates full width mixin header * Fixes Colors Sassdoc default doc * Updates CSS output for media mixin * Updates Sassdocs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #275
This PR adds a new grid partial which sets up wd_s to use a
container>row>colstructure. This structure will generally prove most useful when we build custom modules using ACF or other page builder / meta plugins.This PR also removes a lot of our old structural wraps. Rather than opt-out, I feel wraps should be opt-in. I think all devs are hesitant to remove long-standing code even if it gets in the way or no longer serves a purpose, and by removing them wholesale from the theme, we are more easily enabling devs to use our new
container>row>colas needed.With that said, I was able to trim down our
layoutpartial quite significantly. I completely removed the.wraprule, and cleaned up / consolidated a lot of the other styles. Instead of declaring separate width rules for ourprimaryandsecondaryclasses, I DRY-d up the code and utilized our slick newcolclasses instead.I truly believe this update will enable us to fuss less with grid setup, and is a move in the right direction in terms of keeping our code DRY and more performant.
Again, I'm creating this PR more so that this can be merged into feature/utilities-cleanup, and subsequently into master. More for tracking purposes. :)