Use PX on all grid items #272
Assignees
Milestone
Comments
|
I'm going to have a look into this, do some testing, and see if the kinks regarding the weirdness you experienced on IH are ironed out. My gut says this should be fixed. We already have the But again, this all warrants further testing, which I'll get on and let you know what I come back with. 😄 |
|
So, I have a very similar Bourbon / Neat grid set up in my personal starter theme, and have recently run into weirdness when using I'd also like propose simplifying breakpoint variables to use just a regular ol' $tablet-portrait-up: (
media: 600px,
);This would make it much easier to do calculations on the breakpoints, which is really helpful when using our new |
carrieforde
added a commit
that referenced
this issue
Jul 19, 2017
* Updates media query breakpoints to use pixels This also removes the -up from the variable name to keep with current convention * Updates variable names throughout theme * Updates media query to remove 1px if a breakpoint variable is used * compiled styles
gregrickaby
pushed a commit
that referenced
this issue
Jul 21, 2017
* Updates .wrap to use $max-width * Removes omega reset mixin Neat 2.0.0 no longer uses right-margin, which is why this mixin was useful in the first place * Moves units of measure from mixins to functions directory This is now called earlier in our main style.scss file, and can be used for calculations within the variables file * Remoces $base-context declaration from typography, and adds it to units-of-measure * Updates breakpoints to use em, and aligns with internal coding standards * Removes phone-portrait map, which was only a 1px query 😬 * Adds a get-gutter function for getting the gutter out of a custom grid Sass map * Adds Sassdoc annotations * Adds the grids classes mixin * Adds a media mixin to aid in writing media queries * Adds super-basic scaffolding for a grid system * compiled styles * Sets up partial for colors mixin * Adds colors mixin * Adds $theme-colors Sass map * Adds colors partial for creating our color presentational classes * compiled styles * Adds color as a param for SVG function * Updates svg function to use display terminology * Adds Sassdoc as npm dependency * Adds Sassdoc gulp task * Initial run of Sassdoc 🎉 * Fixes doc comments * Removes Sassdoc-esque comment * Adds basic description to reverse list function * Updates index.html for Sassdoc * Adds Sassdoc comment * Removes extra poster comment for Sassdoc * Updates gutter function and adds better Sass docs * Updates gutter function * Moves em function into its own file * Moves rem function into its own partial * Moves line-height function to its own partial * Updates units of measure to strip-units * Adds separate base-context partial * Moves reverse list function to functions directory * Adds full Sassdoc to vertical align * Removes vendor prefixes (no longer required per caniuse & internal browser requirements) * Updates param line in Sassdoc * Adds sassdocs to media mixin * compiled styles & sassdoc * Adds Sassdoc block * Updates global media breakpoints (#307); fixes #229 * adds new breakpoints and updates documentation * updates grid settings to utilize the new breakpoints — removes now unused breakpoints * Update breakpoint variables (#309) * adds new breakpoints and updates documentation * updates grid settings to utilize the new breakpoints — removes now unused breakpoints * Replace breakpoint variables (adds -up suffix where applicable) from breakpoint/grid updates so compiles don't break. * Feature/#272 use px on all grid items (#316) * Updates media query breakpoints to use pixels This also removes the -up from the variable name to keep with current convention * Updates variable names throughout theme * Updates media query to remove 1px if a breakpoint variable is used * compiled styles * Feature/#275 use more semantic containers (#317) * Updates grid partial name * Adds full width mixin * Adds content width variable * Adds more helpful comments * Adds better column classes and full width class * Removes full-width class from media partial * Adds a page template that contains sidebar This allows us to blow up the sidebar in our regular page template 😄 * Removes sidebar from standard page template 💥 * Fixes template name * Removes wrap class styles & adds padding to primary & secondary * Adds new column classes * Removes primary / secondary styles in favor of using column classes * Removes all the wraps 👋 💥 * Adds new semantic grid classes to ACF content blocks * Adds has-sidebar to single posts by default * Removes extra padding declarations & adds primary styling when sidebar is present * Removes left / right padding so comments are aligned with content & header / footer by default * Updates Sassdoc * compiled styles * Theme/#314 remove em move back to px and rem (#318) * Removes em and reverts back to rem Some of the updates ensure things like borders meet our internal guidelines (px) * Removes custom grids I've never seen these used, and they're easy enough to spin up * Adds a transitions partial to standardize our transitions * Updates partials to use transition variables * Updates border radii to use the $border-radius variables * compiled styles * Updates full width mixin header * Fixes Colors Sassdoc default doc * Updates CSS output for media mixin * Updates Sassdocs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I know this goes against our WDS standard, but given the issues we ran into on IH, I feel like if pixels good enough for Bootstrap (and %'s for Foundation), than we should stick with a unit that doesn't compound.
The text was updated successfully, but these errors were encountered: