-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace hamburger menu/icon with mobile app-esque navigation menu #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us of parent menu items.
…-JS (in progress)
…; adjust styles and functionality for non-JS users
…orner to be closer to the (right-handed) user's thumb.
…irst in the mobile menu section. If a menu is attached to this location, use it. Otherwise, use the primary menu.
…llow menu items to be evenly distributed regardless of menu item number.
This PR got pretty far out of sync and was a fork rather than a branch, which made merging changes a bit more difficult. I created a new branch off of master and manually moved my changes over. New PR here: #171 This one can probably be closed out and the mobile nav changes tracked in the new PR above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket #137
This replaces the hamburger menu/icon with a navigation menu that sits at the bottom of the screen much like a mobile app.
Basic Menu:
Menu styled with icons:
Opening the "More" drawer:
Switching between submenus:
A second tap allows the user to travel the parent menu item's page:
When JS is disabled: