Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring Back The Hamburger Nav #250

Closed
gregrickaby opened this issue Mar 10, 2017 · 4 comments
Closed

Bring Back The Hamburger Nav #250

gregrickaby opened this issue Mar 10, 2017 · 4 comments
Assignees
Labels

Comments

@gregrickaby
Copy link
Contributor

gregrickaby commented Mar 10, 2017

Yes. I said it.

Since we merged in #150 last February, only two of the thirteen (2-13) projects (I've been on) have used the Tap Bar. One of them was WDS8, and the other? Well, the client just asked us to swap it out for the Hamburger nav. :(

It's ultimately the client's choice - and clients are choosing two buns with some meat.

I propose we bring it back, but make it better than it was. I really like the animation on this one: http://codepen.io/taniarascia/details/dYvvYv

Thoughts?

@bezierer
Copy link
Contributor

Dropping a note that @jomurgel did a similar animation for https://www.thesportsgeek.com/ which turned out really nice. I'm in favor of this change and we can always add the tap bar in on a project-basis if it's warranted, too.

@carrieforde
Copy link
Contributor

Maybe we can drop the ol' tapbar navigation into WDS Components so we have it to hand when we need it?

@gregrickaby
Copy link
Contributor Author

gregrickaby commented Mar 15, 2017

This morning our fireteam discussed doing a push drawer similar to this: https://tympanus.net/Development/SidebarTransitions/ (click "Push")

We'd keep the registered mobile menu, hook it into the footer, and just show the drawer on mobile when a user taps the 'ol hamburger nav.

This seems to be what clients want these days. Thoughts?

@gregrickaby
Copy link
Contributor Author

gregrickaby commented Apr 14, 2017

I'm officially calling the ol tapbar dead 💀 . It was included in WDS8, and then it was squashed by Brad in favor of the off canvas drawer + 🍔 . So that brings the tally down to 0-13.

I'm going to work on getting an off canvas drawer with hamburger style nav brought back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants