Rely on variants #360
Merged
Rely on variants #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyaxt
approved these changes
Jan 6, 2019
| identifies one of those headers that enforces the integrity of the exchange's | ||
| payload. | ||
| refresh that signature. Each signature directly signs the exchange's URL and | ||
| headers and identifies one of those headers that enforces the integrity of the |
There was a problem hiding this comment.
Should we clarify that they are response headers to align with your other edits?
There was a problem hiding this comment.
Yes. I'll do that in the morning before I merge.
nyaxt
reviewed
Jan 7, 2019
| this returned "invalid" or didn't return a certificate chain, return | ||
| "invalid". | ||
| 1. Let `exchange` be the exchange metadata and headers parsed out of `headers`. | ||
| 1. If `exchange`'s request method is not safe (Section 4.2.1 of {{!RFC7231}}), |
There was a problem hiding this comment.
I think we ban POST method by this "not safe" check. (POST is actually cachable per https://tools.ietf.org/html/rfc7231#section-4.2.3 ). Should we keep this check?
There was a problem hiding this comment.
This line did ban POST, but since the headers can't encode a method anymore, I don't think we need to keep it.
There was a problem hiding this comment.
Ah I missed that. Thanks for the explanation :)
This was referenced Jan 7, 2019
In favor of using the Variants response header.
17ff994 to
c7afd7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on httpwg/http-extensions#744. @mnot should probably take a look.
Preview | Diff