Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need the :method header? #70

Closed
jyasskin opened this issue Jun 10, 2017 · 5 comments
Closed

Do we need the :method header? #70

jyasskin opened this issue Jun 10, 2017 · 5 comments
Assignees

Comments

@jyasskin
Copy link
Member

#60 (comment) points out that we might not want to store the :method header in requests. We only know of uses of GET requests, and having the ability to code other methods might cause bugs.

@bmeck
Copy link
Collaborator

bmeck commented Jun 21, 2017

I vote it is uneeded.

@jyasskin jyasskin self-assigned this Jun 26, 2017
@ibnesayeed
Copy link
Contributor

From an archival perspective it might be important to keep it. Also, apart from GET there are other methods that might be useful, such as, HEAD and OPTIONS or any other methods that do not change the state of the resource.

@jyasskin
Copy link
Member Author

jyasskin commented Jan 3, 2019

We'd already restricted the method to be safe and [cacheable] (https://tools.ietf.org/html/rfc7231#section-4.2.3). Since the creation of HTTP, only GET and HEAD have met those requirements, and HEAD responses can be synthesized from a stored GET response. So #360 is dropping the :method field (since it would be the only remaining field in the request map).

@jyasskin
Copy link
Member Author

#360 is merged. If a particular archival use case comes up, we can reopen the question.

@ibnesayeed
Copy link
Contributor

@jyasskin do we have a way to support OPTIONS request without this header? If not, then how will the CORS requests work that need pre-flight requests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants