Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update subhub link checker deps #226

Merged
merged 11 commits into from
Feb 23, 2022
Merged

Update subhub link checker deps #226

merged 11 commits into from
Feb 23, 2022

Conversation

uoa-noel
Copy link
Member

@uoa-noel uoa-noel commented Feb 15, 2022 •
edited by rosemcc
Loading

Description

Fix: This PR updates dependencies in subhub-link-checker in order to resolve security advisories, and makes changes to code in order to make it work with updated packages. It also changes Promise-based functions in subhub-link-checker into async/await functions to improve readability.

Solution

Packages are bumped using npm audit fix and Contentful's Forma 36 migration codemod. Manual testing and code changes were then done to address glitchy scrollbars and remove calls to deprecated methods. Unused stub component pages are removed.

More documentation is also added for deploying subhub-link-checker.

Screenshots

No UI change.

Testing

No changes requiring new unit and E2E testing.

Manual testing

  • Go to Contentful, and switch environment to dev, where these changes are applied.
  • Go to the subhub He Korowai Mātauranga (or any other subhub.)
  • Go to the Internal pages field. The field should be rendered with internal pages references. Select Add content > Add existing content.
  • Try adding the subhub page itself. This should give a "link check failed" dialog and the item should not be added as a reference.
  • Try adding another page that already belongs to another subhub, e.g. Nectar Research Cloud. This should give a "link check failed" dialog and the item should not be added as a reference.
  • Try adding a page that doesn't belong to another subhub, e.g. Open Access. This should succeed.
  • Publish the change and go to the corresponding topic page on dev. The new item should be shown.
  • Remove the page reference and hit Publish to clean up.

Have the changes been checked in the following browsers?

  • Chrome
  • Safari
  • Firefox
  • Edge

rosemcc
rosemcc approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@rosemcc rosemcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've tested in Edge - seems fine. Maybe get Cam or Lukas to test on Safari.

@uoa-noel uoa-noel requested a review from Trombach February 16, 2022 00:38
@Trombach
Copy link
Contributor

Trombach commented Feb 16, 2022 •
edited
Loading

Manual testing in Safari 15.3 was successful.

@uoa-noel uoa-noel merged commit 32f8425 into master Feb 23, 2022
rosemcc added a commit that referenced this pull request Feb 24, 2022
@rosemcc @dependabot
@Trombach @uoa-noel
Rc2.6.0 (#237)
9f3905a 
* delete unused components

* show external links icons

* tweaks to card titles for consistency

* navigateTo changed to window.open, fix typo

* minor fixes

* close search autocomplete panel on enter keypress

* readme

* chore: version bump

* Bump nodemon from 2.0.12 to 2.0.15 in /cer-graphql

Bumps [nodemon](https://github.com/remy/nodemon) from 2.0.12 to 2.0.15.
- [Release notes](https://github.com/remy/nodemon/releases)
- [Commits](remy/nodemon@v2.0.12...v2.0.15)

---
updated-dependencies:
- dependency-name: nodemon
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* external links icon not on phone numbers

* fix link card external icon

* cards external links functionality and accessibility

* fix tabbing on contact card

* open assets in new tab

* dont show external link icon on home page banner content

* chore: add subhub-link-checker to dependabot.yml

* Bump contentful-export from 7.13.34 to 7.14.11 in /hub-search-proxy

Bumps [contentful-export](https://github.com/contentful/contentful-export) from 7.13.34 to 7.14.11.
- [Release notes](https://github.com/contentful/contentful-export/releases)
- [Commits](contentful/contentful-export@v7.13.34...v7.14.11)

---
updated-dependencies:
- dependency-name: contentful-export
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* npm update, lock @elastic/elasticsearch version to 7.13.0 due to breaking change in v7.14+

* Bump nodemon from 2.0.12 to 2.0.15 in /cer-graphql

Bumps [nodemon](https://github.com/remy/nodemon) from 2.0.12 to 2.0.15.
- [Release notes](https://github.com/remy/nodemon/releases)
- [Commits](remy/nodemon@v2.0.12...v2.0.15)

---
updated-dependencies:
- dependency-name: nodemon
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* updated dev dependencies

* more updates

* Persistent Notification (#202)

* added animation to notification

* 1st version remember persistant notification

* refactored notification request into service

* formatting

* code cleanup and comments

* minor fix to method description

* more changes to comments

* unit tests for getNotification() function

* removed some unused code from unit test

* added test for storeCurrentNotificationVersion

* improved close function

* removed focused describe

Co-authored-by: Rose <31844476+rosemcc@users.noreply.github.com>

* added filter counter to tab labels (#208)

* remove unused dependencies and use lockfile version 2 (#207)

* remove unused dependencies and use lockfile version 2

* update sentry to latest

* update rxjs, npm audit fix

* fix interface change to iif() in rxjs 7

* fix chunkload error

Co-authored-by: rosemcc <rosemccoll@hotmail.com>

* chore: add PR templates

* chore: generic PR template

* chore: delete separate PR templates

* Angular-13.1 (#211)

* update ng-mocks

* update @angular/cli

* update @angular/material @angular/core

* npm update

* removed workaround for mat-card-image on picture tags

* added missing mat-card-image directive

* fixed default images not rendered properly, minor re-factor

* minor tidy up

* update karma version

* Service worker (#210)

* ng add @angular/pwa

* set theme-color

* replace default Angular icons with UoA

* clean up codeCoverageExclude

* readme

* Material icons and fonts caching

* Revert "Material icons and fonts caching"

This reverts commit 14b2e3c.

* material icons, uoa fonts, contentful assets caching, readme

* lazy fetch contentful assets

* service worker on prod index.html

* App name

* add script to run in service worker mode locally

* csp update WIP

* 504 gateway timeout bypass

* sw updates service WIP

* note

* unit tests passing

* more csp updates due to service worker fetching

* about link fix on footer

* adding sw-updates functionality

* add nontransparent icon for apple-touch-icon

* replace deprecated methods, add error handling

* package-lock fix after merge

* tidying, add types

* material dialog for update confirmation

* tests passing

* Change dialog to snackbar, add styling

* add a test

* remove unused material modules

* button style

* minor update to script and readme for running service worker locally

* fix snackbar style

* add app id to manifest

* refactor swUpdates, add tests

* remove f

* add maskable icons

* icons fix

* add apple touch icon

* changes to pipe and unit test

* remove unused imports

Co-authored-by: Luke <lukas.trombach@auckland.ac.nz>

* Bump contentful-export from 7.14.11 to 7.14.27 in /hub-search-proxy

Bumps [contentful-export](https://github.com/contentful/contentful-export) from 7.14.11 to 7.14.27.
- [Release notes](https://github.com/contentful/contentful-export/releases)
- [Commits](contentful/contentful-export@v7.14.11...v7.14.27)

---
updated-dependencies:
- dependency-name: contentful-export
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump @graphql-codegen/typescript in /research-hub-web

Bumps [@graphql-codegen/typescript](https://github.com/dotansimha/graphql-code-generator/tree/HEAD/packages/plugins/typescript/typescript) from 1.23.0 to 2.4.3.
- [Release notes](https://github.com/dotansimha/graphql-code-generator/releases)
- [Changelog](https://github.com/dotansimha/graphql-code-generator/blob/master/packages/plugins/typescript/typescript/CHANGELOG.md)
- [Commits](https://github.com/dotansimha/graphql-code-generator/commits/@graphql-codegen/typescript@2.4.3/packages/plugins/typescript/typescript)

---
updated-dependencies:
- dependency-name: "@graphql-codegen/typescript"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update for Terraform AWS Provider v4.0.0 (#225)

* s3 bucket config updates for provider v4

* add missing indices on secondary website bucket configs

* add version constraint for AWS provider

* Dependency cleanup (#229)

* remove nodemon and webdriver manager, remove unneeded script

* remove apollo-link

* remove aws4 and aws-sdk

* Merge branch 'master' into dependency-cleanup

* more unused deps

* update jasmine-core, npm audit fix

* package updates, fix ngx-markdown breaking change

* package-lock

* update sentry, date-fns

* update @angular/core to 13.2.3

* update @angular-eslint/schematics to 13.1.0

* added graphql devDependency for codegen

Co-authored-by: Lukas Trombach <lukas.trombach@auckland.ac.nz>

* Update subhub link checker deps (#226)

* Update versions

* Update f36 deps

* Update to use new methods

* Rewrite promises as async blocks

* Bump @types/react-dom version

* Run npm audit fix

* Add more instructions for deployment

* Add note about official release process

* Update package lock file to use v2
- Also remove unused imports

* Search Cards Linking Behaviour (#231)

* add anchor tag over whole card, fix title styling

* Update research-hub-web/src/app/components/search-page/search-results-list/search-results-list.component.html

Co-authored-by: Lukas Trombach <19306765+Trombach@users.noreply.github.com>

* fix link

* fix link

Co-authored-by: Lukas Trombach <19306765+Trombach@users.noreply.github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lukas Trombach <19306765+Trombach@users.noreply.github.com>
Co-authored-by: Luke <lukas.trombach@auckland.ac.nz>
Co-authored-by: Noel <39939032+uoa-noel@users.noreply.github.com>
@rosemcc rosemcc deleted the update-subhub-link-checker-deps branch March 13, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosemcc rosemcc rosemcc approved these changes

@Trombach Trombach Awaiting requested review from Trombach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uoa-noel @Trombach @rosemcc