Re-introduce prime_tower_enable
#18403
Conversation
| @@ -55,6 +55,7 @@ | |||
| "settable_per_extruder": false | |||
| }, | |||
| "prime_blob_enable": { "default_value": false }, | |||
There was a problem hiding this comment.
Overriding prime_blob_enable with the same value (default_value: False) as defined in parent definition: fdmprinter
| "prime_blob_enable": { "default_value": false }, | |
| @@ -44,8 +44,8 @@ | |||
| "machine_width": { "default_value": 235 }, | |||
| "meshfix_maximum_resolution": { "value": 0.25 }, | |||
| "optimize_wall_printing_order": { "value": true }, | |||
There was a problem hiding this comment.
Overriding optimize_wall_printing_order with the same value (value: True) as defined in parent definition: fdmprinter
| "optimize_wall_printing_order": { "value": true }, | |
| "prime_tower_min_volume": { "value": 30 }, | ||
| "prime_tower_mode": { "value": "'normal'" }, | ||
| "retract_at_layer_change": { "value": false }, |
There was a problem hiding this comment.
Overriding retract_at_layer_change with the same value (value: False) as defined in parent definition: fdmprinter
| "retract_at_layer_change": { "value": false }, | |
prime_tower_enableprime_tower_enable
There was a problem hiding this comment.
Just a minor remark, I can make the change if you agree with it.
By the way, this change makes more and more sense to me. Some printers forcibly activate or deactivate the prime tower, so when forcing a mode instead, it wouldn't allow them to use the optimized "interleaved" mode. Now they can forcibly enable it, and the mode will depend on the actual materials, which is really expected.
|
I see a lot of settings in fdmprinter.def.json that still rely on |
Co-authored-by: Erwan MATHIEU <erwan.mathieu@ultimaker.com>
Description
Previously we introduced new settings related to the prime tower. Specifically the setting
prime_tower_enablewas changed toprime_tower_modewhereprime_tower_enable=Falseis reinterpreted toprime_tower_mode=Noneandprime_tower_enable=Trueis can be eitherprime_tower_mode=Normalorprime_tower_mode=Interleaved.This reinterpretation poses some issues related to upgrade script, value resolving etc. Additionally it isn't consistent with how settings are defined elsewhere. For example, for the support setting we have two settings, namely:
(bool)support_enabledand(enum)support_modewheresupport_modecan be eithertreeornormal. Following this same logic we should have introduced(bool)prime_tower_enableand(enum)prime_tower_mode.also see enginge PR Ultimaker/CuraEngine#2033
CURA-11645
Type of change
How Has This Been Tested?
Yas
Test Configuration:
Checklist: