feat(APIM-609): companies house - extend returned fields #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5dc09e6 to
3a3dc97
Compare
|
abhi-markan
added a commit
that referenced
this pull request
Dec 17, 2024
🤖 I have created a release *beep* *boop* --- ## [1.22.0](v1.21.6...v1.22.0) (2024-12-17) ### Features * **APIM-608:** gov notify - file upload/link support ([#1083](#1083)) ([dddf3e6](dddf3e6)) * **APIM-609:** companies house - extend returned fields ([#1089](#1089)) ([041124c](041124c)) * **APIM-610:** markets - add country rating description field ([#1090](#1090)) ([11ec0d4](11ec0d4)) ### Bug Fixes * **APIM-608:** eslint downgraded ([b0e349c](b0e349c)) * **APIM-608:** make GovNotify properties optional ([#1082](#1082)) ([9240907](9240907)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
In order for Companies House to be consumed by other products/services, the integration needs to return some additional fields.
Note: unfortunately, some methods in the Companies House service do not have unit test coverage as they are private methods. I would like to add unit tests for all private methods (likely needing to make them public or extracted into helper functions), but this would be a bigger change than introducing additional fields.
Resolution ✔️
CompaniesServiceto return the following additional data:accountsobjectdateOfCreationregisteredAddress.careOfregisteredAddress.premisesregisteredAddress.regionTodo ❗