Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(APIM-608): make GovNotify properties optional #1082

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Conversation

abhi-markan
Copy link
Contributor

@abhi-markan abhi-markan commented Dec 6, 2024

Introduction ✏️

Make unsubscribe_link and scheduled_for properties are set to optional for strict schema validation.

Resolution ✔️

  • Set the required to false.

Miscellaneous ➕

  • Dependencies updates.
  • Added additional validation scripts to package.json

ttbarnes
ttbarnes previously approved these changes Dec 6, 2024
@abhi-markan abhi-markan changed the title fix(APIM-608): make unsubscribe link optional fix(APIM-608): make GovNotify properties optional Dec 6, 2024
Copy link

sonarqubecloud bot commented Dec 6, 2024

@abhi-markan abhi-markan merged commit 9240907 into main Dec 6, 2024
17 checks passed
@abhi-markan abhi-markan deleted the fix/gov-notify branch December 6, 2024 13:34
abhi-markan added a commit that referenced this pull request Dec 17, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.22.0](v1.21.6...v1.22.0)
(2024-12-17)


### Features

* **APIM-608:** gov notify - file upload/link support
([#1083](#1083))
([dddf3e6](dddf3e6))
* **APIM-609:** companies house - extend returned fields
([#1089](#1089))
([041124c](041124c))
* **APIM-610:** markets - add country rating description field
([#1090](#1090))
([11ec0d4](11ec0d4))


### Bug Fixes

* **APIM-608:** eslint downgraded
([b0e349c](b0e349c))
* **APIM-608:** make GovNotify properties optional
([#1082](#1082))
([9240907](9240907))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants