generated from UK-Export-Finance/nestjs-template
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(APIM-608): make GovNotify properties optional #1082
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttbarnes
reviewed
Dec 6, 2024
ttbarnes
approved these changes
Dec 6, 2024
ttbarnes
previously approved these changes
Dec 6, 2024
abhi-markan
changed the title
fix(APIM-608): make unsubscribe link optional
fix(APIM-608): make GovNotify properties optional
Dec 6, 2024
stevewinsladeukef
approved these changes
Dec 6, 2024
Quality Gate passedIssues Measures |
ttbarnes
approved these changes
Dec 6, 2024
abhi-markan
added a commit
that referenced
this pull request
Dec 17, 2024
🤖 I have created a release *beep* *boop* --- ## [1.22.0](v1.21.6...v1.22.0) (2024-12-17) ### Features * **APIM-608:** gov notify - file upload/link support ([#1083](#1083)) ([dddf3e6](dddf3e6)) * **APIM-609:** companies house - extend returned fields ([#1089](#1089)) ([041124c](041124c)) * **APIM-610:** markets - add country rating description field ([#1090](#1090)) ([11ec0d4](11ec0d4)) ### Bug Fixes * **APIM-608:** eslint downgraded ([b0e349c](b0e349c)) * **APIM-608:** make GovNotify properties optional ([#1082](#1082)) ([9240907](9240907)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
Make
unsubscribe_link
andscheduled_for
properties are set to optional for strict schema validation.Resolution ✔️
required
to false.Miscellaneous ➕
package.json