Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion = 'to' #6036

Closed
dandyjay opened this issue Jul 19, 2022 · 6 comments · Fixed by #6066
Closed

Conversion = 'to' #6036

dandyjay opened this issue Jul 19, 2022 · 6 comments · Fixed by #6066

Comments

@dandyjay
Copy link

What steps will reproduce the problem?

  1. type one of many commands (/t deposit, /t set taxes, among others)
  2. command functions properly, but in chat this message is returned:
    image

What is the expected output?

proper command response

Towny version

0.98.3.2

Server version

paper 1.18.2 build number 380

Please use Pastebin.com to link the following files

  1. Your full server startup from the logs\latest.log: https://pastebin.com/1363JaWL
  2. Your Towny config.yml: https://pastebin.com/RHE6zRyy
  3. Your townyperms.yml: https://pastebin.com/87PnR0Sp
  4. Your log's error: N/A no error thrown in console

(optional) If this is to do with permissions,
5. Your permissions file: N/A

(optional) If this is to do with chat,
6. Your chatconfig.yml: not using towny chat
7. Your channels.yml: not using towny chat

@dandyjay dandyjay added the bug label Jul 19, 2022
@LlmDl
Copy link
Member

LlmDl commented Jul 19, 2022

Show me your language file you changed.

@LlmDl LlmDl added the Need Feedback Something is required of the submitter. Tickets will be closed after 14 days with no feedback. label Jul 19, 2022
@dandyjay
Copy link
Author

there's also a strange lack of messages for certain commands, i.e. in console:
19.07 21:09:27 [Server] INFO KA1ZEN_ issued server command: /towny:t invite accept DANDYCORP
19.07 21:09:27 [Server] INFO [Nation Msg] DANDYCORP: The town of Porkalorpolis joined the nation!
but in game:
image
nothing

@dandyjay
Copy link
Author

Show me your language file you changed.

my language files are default except for the global override in which i have


# Global language file override file.
# Here you can add your own messages, and they will be applied to each language.
# To add messages for specific languages, copy the file from the reference folder to this one, and alter the messages.

# Messages can be added like so: (hint: remove the # to uncomment it)
default_towny_prefix: '&8&l[&#8200ff&lBITREALM&8&l] &b'
default_town_prefix: '&8&l[%townyadvanced_town_map_color_hex%%s&8&l] &b'
default_nation_prefix: '&8&l[%townyadvanced_town_map_color_hex%%s&8&l] &b'
msg_err_friendly_fire_disable: ''

@LlmDl
Copy link
Member

LlmDl commented Jul 19, 2022

Remove the %townyadvanced_town_map_color_hex% from your default_town_prefix and default_nation_prefix. We don't parse placeholders there and that is what is causing your issue. Probably the same thing in your SiegeWar ticket.

@dandyjay
Copy link
Author

wow, sure enough. cheers.
is there any way to achieve what i'm trying to do with the colored town prefixes based on their dynmap color? i like the ability for players to customize their stuff.

@LlmDl
Copy link
Member

LlmDl commented Jul 19, 2022

I don't believe so.

@LlmDl LlmDl added Completed and removed Need Feedback Something is required of the submitter. Tickets will be closed after 14 days with no feedback. labels Aug 3, 2022
@LlmDl LlmDl added this to the 0.98.4.0 milestone Aug 3, 2022
LlmDl added a commit that referenced this issue Aug 3, 2022
  - Add option to disallow numbers in town/nation names, courtesy of
Warriorrrr with PR #6068.
    - Closes #5954.
  - Allow spaces to be used in town/nation rename commands, courtesy of
Warriorrrr with PR #6067.
  - Make it easier to debug lang file formatting errors, courtesy of
Warriorrrr with PR #6066.
    - Closes #6036.
  - Fix /t deposit & /n deposit running sync, courtesy of Warriorrrr
with PR #6064.
  - Include the plot price in the /plot fs feedback message, courtesy of
Warriorrrr with PR #6062.
  - Ensure player gets feedback message when setting a group for sale,
courtesy of Warriorrrr with PR #6060.
  - Re-check group set cost after confirmation is accepted, courtesy of
Warriorrrr with PR #6058.
  - Add admin town command upkeep toggle, courtesy of Gamer153 with PR
#6052. (First-Time Contributor!)
  - New Command: /ta town NAME toggle upkeep
    - Toggles upkeep on or off for the given town.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants