Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Option for disabling numbers in town and nation names. #5954

Closed
Wextra opened this issue Jun 11, 2022 · 2 comments · Fixed by #6068
Closed

Suggestion: Option for disabling numbers in town and nation names. #5954

Wextra opened this issue Jun 11, 2022 · 2 comments · Fixed by #6068
Labels
Completed enhancement
Milestone
0.98.4.0

Comments

@Wextra
Copy link

Wextra commented Jun 11, 2022

Please explain your feature request to the best of your abilities:

As mentioned in the title, I would suggest adding an option for disabling numbers in town and nation names. The only way to do it right now is to remove numbers from the regex, which does however instead result in different parts of towny not working.
@ggvbo
Copy link
Contributor

ggvbo commented Jun 21, 2022

What do you mean by "different parts of Towny not working"? You shouldn't really have any issues with that, it would be nice if you could elaborate on it, that way we can also help you with your suggestion

@Wextra
Copy link
Author

Wextra commented Jun 21, 2022

I talked to LlmDl about it. Removing numbers from the regex means that towny for example can not create NPC mayors, as those NPCs have numbers in their names (e.g. NPC1, NPC2). A regex without numbers in it means that these names can not be created, and as such doing /ta set mayor npc breaks the town.

@Warriorrrr Warriorrrr mentioned this issue Jul 27, 2022
Merged
1 task
@LlmDl LlmDl added the Completed label Aug 3, 2022
@LlmDl LlmDl added this to the 0.98.4.0 milestone Aug 3, 2022
LlmDl added a commit that referenced this issue Aug 3, 2022
@LlmDl
- Create our own wrapper impl, courtesy of Warriorrrr with PR #6075.
28196cc 
  - Add option to disallow numbers in town/nation names, courtesy of
Warriorrrr with PR #6068.
    - Closes #5954.
  - Allow spaces to be used in town/nation rename commands, courtesy of
Warriorrrr with PR #6067.
  - Make it easier to debug lang file formatting errors, courtesy of
Warriorrrr with PR #6066.
    - Closes #6036.
  - Fix /t deposit & /n deposit running sync, courtesy of Warriorrrr
with PR #6064.
  - Include the plot price in the /plot fs feedback message, courtesy of
Warriorrrr with PR #6062.
  - Ensure player gets feedback message when setting a group for sale,
courtesy of Warriorrrr with PR #6060.
  - Re-check group set cost after confirmation is accepted, courtesy of
Warriorrrr with PR #6058.
  - Add admin town command upkeep toggle, courtesy of Gamer153 with PR
#6052. (First-Time Contributor!)
  - New Command: /ta town NAME toggle upkeep
    - Toggles upkeep on or off for the given town.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Completed enhancement
Projects
None yet
Milestone
0.98.4.0
Development

Successfully merging a pull request may close this issue.

Add option to disallow numbers in town/nation names TownyAdvanced/Towny
3 participants
@LlmDl @Wextra @ggvbo