Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return result instead of Future from os funcs wrapper #54

Conversation

gyermolenko
Copy link
Contributor

Since support for python3.4 was dropped from the lib I've tried to change from yield from syntax to awaits.

Immediately got into AttributeError: 'Future' object has no attribute st_size in test_os.py::test_stat. Change is small but in return type, so I decided to show it separately.

And another one: here __iter__ has @asyncio.coroutine. I don't think it should (and tests pass without it too :) )

@gyermolenko
Copy link
Contributor Author

hi @Tinche , just a ping

@gyermolenko
Copy link
Contributor Author

hi @Tinche .
Just a kind reminder.. I am very interested in your thoughts about this PR.
(about yield from -> await transition; @asyncio.coroutine above __iter__ etc).

@Tinche
Copy link
Owner

Tinche commented Apr 16, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants