Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.8 deprecation warnings #70

Closed
davesteele opened this issue Jan 9, 2020 · 7 comments
Closed

Python 3.8 deprecation warnings #70

davesteele opened this issue Jan 9, 2020 · 7 comments

Comments

@davesteele
Copy link
Contributor

davesteele commented Jan 9, 2020

e.g.
/home/daves/github/aiofiles/.pybuild/cpython3_3.8/build/aiofiles/threadpool/utils.py:33: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
def method(self, *args, **kwargs):

.pybuild/cpython3_3.8/build/tests/test_simple.py::test_serve_small_bin_file_sync
/home/daves/github/aiofiles/.pybuild/cpython3_3.8/build/tests/test_simple.py:28: DeprecationWarning: The loop argument is deprecated since Python 3.8, and scheduled for removal in Python 3.10.
server = yield from asyncio.start_server(serve_file, port=unused_tcp_port,

@fakegermano
Copy link

fakegermano commented Apr 6, 2020

I have this warning too, but they explicitly state that they only support up to python 3.7
But I believe supporting 3.8 is in the roadmap (#68) , and fixing this issue will be necessary for that step.

@Tinche
Copy link
Owner

Tinche commented Apr 11, 2020

I believe these are fixed in the latest release!

@Tinche Tinche closed this as completed Apr 11, 2020
@colidyre
Copy link

I believe these are fixed in the latest release!

@Tinche Do you mean on the master branch instead of the tagged release? I have also DeprecationWarning with Pytest on os.py:8 with the latest release 0.5.0 as already mentioned in #74 (which mentioned also #75 and #54).

See the differences for master and latest release 0.5.0 for example. It would be nice to have a tagged version to get rid of the Python3.8 warnings for this version.

@samuelcolvin
Copy link

@Tinche any chance you could create a new release to include the fix for this?

@Tinche
Copy link
Owner

Tinche commented Oct 26, 2020

I'll cut a new release tomorrow!

@Tinche
Copy link
Owner

Tinche commented Oct 27, 2020

Released!

@samuelcolvin
Copy link

thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants