Cancel non-ancestor popups when showing a new popup #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses GH TiddlyWiki#3484 As far as I can tell, the popup level checks in this module are meant to handle nested popups. It seems to me that the goal is for at most a single hierarchy of popups to exist at any given time - bearing that in mind, this change checks any popups currently tracked by the module, canceling any that don't share an element hierarchy with the new popup.
|
My cursory tests with this change work; I'm going to add this code to my own wiki and see if any bugs fall out over the next few days. |
Closed
|
Thanks @hoelzro |
Closed
BurningTreeC
pushed a commit
to BurningTreeC/TiddlyWiki5
that referenced
this pull request
Nov 26, 2018
Jermolene
pushed a commit
that referenced
this pull request
Nov 29, 2018
jho1965us
pushed a commit
to jho1965us/TiddlyWiki5
that referenced
this pull request
Apr 3, 2019
Addresses GH TiddlyWiki#3484 As far as I can tell, the popup level checks in this module are meant to handle nested popups. It seems to me that the goal is for at most a single hierarchy of popups to exist at any given time - bearing that in mind, this change checks any popups currently tracked by the module, canceling any that don't share an element hierarchy with the new popup.
jho1965us
pushed a commit
to jho1965us/TiddlyWiki5
that referenced
this pull request
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses GH #3484
As far as I can tell, the popup level checks in this module are meant to handle nested popups. It seems to me that the goal is for at most a single hierarchy of popups to exist at any given time - bearing that in mind, this change checks any popups currently tracked by the module, canceling any that don't share an element hierarchy with the new popup.