Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please undo #3490 #3581

Closed
BurningTreeC opened this issue Nov 25, 2018 · 5 comments
Closed

please undo #3490 #3581

BurningTreeC opened this issue Nov 25, 2018 · 5 comments

Comments

@BurningTreeC
Copy link
Contributor

@Jermolene, apologies

#3490 is not ready, I thought it was

it cancels the more-tiddler-actions popup if the export-tiddler popup is shown, resulting that both popups disappear. needs work

@Jermolene
Copy link
Member

Hi @BurningTreeC do you want me to undo it, or will your PR do that?

@BurningTreeC
Copy link
Contributor Author

Hi @Jermolene, would you undo it? My PR doesn't undo this one

@hoelzro
Copy link
Contributor

hoelzro commented Nov 26, 2018

@BurningTreeC Good catch - I'm glad my code didn't manage to break TiddlyWiki! I'm sorry for not working on the popup more; the last month has been a little crazy at home. Working on a fix is now my personal coding time priority though, so I'm going to be working on this - I'm thinking that it won't be ready for 5.1.18, though.

@BurningTreeC
Copy link
Contributor Author

@hoelzro, Hi, don't worry! Have you seen #3309 ? In the end that PR would also accomplish cancelling the popups your PR cancels

@hoelzro
Copy link
Contributor

hoelzro commented Nov 27, 2018

@BurningTreeC I haven't - I'll take a look tomorrow morning!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants