Updates for v1.7.0 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdd717a to
9ec36a5
Compare
…libraries - Add ControllerModifyVolume as an unimplemented method to comply with the CSI v1.9.0 spec. - Embed unimplemented server types in controller, identity, and node servers per CSI v1.10.0 spec requirements. - Replace deprecated e2eframework expects with gomega expects. - Update manager.Options configuration to reflect controller-runtime API changes. Resolves: - https://github.com/ThinkParQ/beegfs-csi-driver/security/dependabot/27 - https://github.com/ThinkParQ/beegfs-csi-driver/security/dependabot/31 - https://github.com/ThinkParQ/beegfs-csi-driver/security/dependabot/29
Due to the previous dependency updates, the old version was incompatible and building the manager would fail: Error: /home/runner/work/beegfs-csi-driver/beegfs-csi-driver/vendor/k8s.io/api/core/v1/doc.go:21:1: missing argument (at <input>)
- Regenerate operator manifests and bundle. - Kubectl deployment manifests. - Nomad deployment manifests.
82c11ea to
61baa3e
Compare
Support for volume expansion required adding the patch verb to the driver’s ClusterRole. To enable seamless upgrades from v1.6 to v1.7, the operator now requires permission to update ClusterRoles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a number of housekeeping items for the driver and operator and prepares for the v1.7.0 release. See individual commits for details.
Dependency Update Notes
This section includes any notes related to updating dependencies not already covered in the commit messages and/or a comment elsewhere.
New Operator Test Warnings
Operator test (
$operator make build test) are now returning a warning that did not previously occur:My initial reaction was that I did not correctly adapt setting up the manager with the new
DefaultNamespacesbut there is no change even if I omit configuring a Cache entirely. Additionally all other functionality is working as expected, including deploying the operator+driver with and without a namespace.The warning is coming from the K8s Go client. I suspect this is an issue with how the tests are being executed, and not actually an issue with the operator. I tried bumping the version of Ginkgo but the error persists. Because this warning appears benign I'm choosing to ignore it for now.