Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with overlapping of delete button with search button #41213 #3

Merged
merged 7 commits into from
Oct 25, 2024
Merged

Deal with overlapping of delete button with search button #41213 #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
017416d
Add padding to cr_buttons to prevent overlap
Alec-Smith29 Oct 20, 2024
820b42c
Change padding to em
Alec-Smith29 Oct 20, 2024
4f5c686
Merge branch 'brave:master' into Deal-with-overlapping-of-delet-butto…
Alec-Smith29 Oct 22, 2024
5e6fc8e
Merge branch 'brave:master' into Deal-with-overlapping-of-delet-butto…
Alec-Smith29 Oct 22, 2024
c96d59a
Merge branch 'brave:master' into Deal-with-overlapping-of-delet-butto…
Alec-Smith29 Oct 24, 2024
9f949ae
Add padding to search field
Alec-Smith29 Oct 24, 2024
964e9ee
Added padding to navigation bar to prevent overlap with menu
Alec-Smith29 Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ui/webui/resources/br_elements/br_toolbar/br_toolbar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@
display: flex;
justify-content: center;
margin: 0;
padding: 6px 0;
padding-right:1em;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good to change padding from fixed pixel values to relative values. This change makes the layout more responsive.

padding-left:1em;
gap: 6px;
}

Expand Down
2 changes: 1 addition & 1 deletion ui/webui/resources/br_elements/br_toolbar/br_toolbar_search_field.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<style>
:host {
--search-icon-size: 20px;
--search-padding: 16px;
--search-padding: 0.5em;
--search-icon-padding: 4px;
--search-button-width: calc(var(--search-icon-size) + 2 * var(--search-padding) + 2 * var(--search-icon-padding));
position: absolute;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might worth consider to test, absolute positioning can sometimes lead to layout issues if not managed properly with respect to parent elements.

Expand Down
1 change: 1 addition & 0 deletions ui/webui/resources/cr_elements/cr_button/cr_button.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export class CrButtonElement extends CrLitElement {
:host {
display: inline-block;
height: min-content;
padding:2em;
}

:host(.cancel-button) {
Expand Down
Loading