Deal with overlapping of delete button with search button #41213 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change padding to em units instead of px so it scales with size instead of constant units
…n-with-search-button
…n-with-search-button
…n-with-search-button
JialinWang000
approved these changes
Oct 24, 2024
| @@ -28,7 +28,8 @@ | |||
| display: flex; | |||
| justify-content: center; | |||
| margin: 0; | |||
| padding: 6px 0; | |||
| padding-right:1em; | |||
There was a problem hiding this comment.
It is good to change padding from fixed pixel values to relative values. This change makes the layout more responsive.
| @@ -1,7 +1,7 @@ | |||
| <style> | |||
| :host { | |||
| --search-icon-size: 20px; | |||
| --search-padding: 16px; | |||
| --search-padding: 0.5em; | |||
| --search-icon-padding: 4px; | |||
| --search-button-width: calc(var(--search-icon-size) + 2 * var(--search-padding) + 2 * var(--search-icon-padding)); | |||
| position: absolute; | |||
There was a problem hiding this comment.
Might worth consider to test, absolute positioning can sometimes lead to layout issues if not managed properly with respect to parent elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Overlapping of Delete button with Search icon #41213 by adding padding. Issue was fixed by adding padding to the delete button to prevent this from happening. Additional padding was also added to the navigation bar and search tool icon as at small resolutions some of these icons also overlapped which made some elements inaccessible.
Ensure that when pushing to the actual brave core we attempt to use github auto-closing keywords
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on