Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating lifecycle_commands and/or interpreter should result in no op #8

Closed
rucciva opened this issue Nov 6, 2020 · 0 comments
Closed

Updating lifecycle_commands and/or interpreter should result in no op #8

rucciva opened this issue Nov 6, 2020 · 0 comments
Assignees
@rucciva
Labels
enhancement New feature or request

Comments

@rucciva
Copy link
Member

rucciva commented Nov 6, 2020 •
edited
Loading

this is to mimic the behavior when provider is update, which will not execute the previous logic.

this invalidate some logic applied in #5
@rucciva rucciva self-assigned this Nov 6, 2020
@rucciva rucciva added the enhancement New feature or request label Nov 6, 2020
@rucciva rucciva changed the title Updated read script should result in no op Updated script should result in no op Nov 6, 2020
@rucciva rucciva changed the title Updated script should result in no op Updating lifecycle_commands should result in no op Nov 6, 2020
rucciva added a commit that referenced this issue Nov 8, 2020
@rucciva
Enhancement for smooth commands update (#8)
b9e50f1
rucciva added a commit that referenced this issue Nov 8, 2020
@rucciva
restore read_error (#8)
4fe5080
@rucciva rucciva closed this as completed Nov 8, 2020
rucciva added a commit that referenced this issue Nov 9, 2020
@rucciva
only forbid input when commands change (#8)
3641b1e
rucciva added a commit that referenced this issue Nov 10, 2020
@rucciva
update to interpreter now result in no op (#8)
c8b295b
rucciva added a commit that referenced this issue Nov 11, 2020
@rucciva
do not run delete when read_failed (#8)
d16cf6b
@rucciva rucciva changed the title Updating lifecycle_commands should result in no op Updating lifecycle_commands and/or interpreter should result in no op Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rucciva rucciva

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rucciva