Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle failed Read phase and updated Read script #5

Closed
rucciva opened this issue Nov 6, 2020 · 0 comments
Closed

Handle failed Read phase and updated Read script #5

rucciva opened this issue Nov 6, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@rucciva
Copy link
Member

rucciva commented Nov 6, 2020

Since read script is also part of state, Read phase will always use the one stored and will ignore the updated one. So maybe when update is triggered and there is a change in read script, we should not execute update script and execute read script instead. If the new read produce change, then subsequent terraform apply need to be run to fully sync the state.

Also if read script fail after Create succeeded, terraform plan will fail, consider adding read_failed attribute and act on it when update. This changes will trigger Destroy->Create if update script is empty. User are left with two options: allow recreation, or manually do something so that read succeeded.

@rucciva rucciva added the bug Something isn't working label Nov 6, 2020
@rucciva rucciva self-assigned this Nov 6, 2020
rucciva added a commit that referenced this issue Nov 6, 2020
- handle updated  and failed read (#5)
@rucciva rucciva closed this as completed Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant