Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Sheet): avoid content from rendering on top of sticky title/buttons #1247

Merged
merged 7 commits into from
Sep 30, 2024
Merged

fix(Sheet): avoid content from rendering on top of sticky title/buttons #1247

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9c2249b
fix zindex in SheetBody
marcoskolodny Sep 25, 2024
daa9eca
use zIndex only in mobile
marcoskolodny Sep 25, 2024
57066f8
add workaround for phonenumberlib
marcoskolodny Sep 25, 2024
97fe5fe
add workaround in acceptance test
marcoskolodny Sep 25, 2024
3f1bab6
Merge branch 'master' of github.com:Telefonica/mistica-web into WEB-2…
marcoskolodny Sep 26, 2024
78ccdff
Merge branch 'master' of github.com:Telefonica/mistica-web into WEB-2…
marcoskolodny Sep 30, 2024
74bb9f1
remove old code
marcoskolodny Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 30 additions & 10 deletions src/sheet-common.css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,19 +236,39 @@ export const overlay = style([

export const closingOverlay = style(overlayClosedStyle);

export const stickyTitle = sprinkles({
position: 'sticky',
top: 0,
background: skinVars.colors.background,
});
export const stickyTitle = style([
sprinkles({
position: 'sticky',
top: 0,
background: skinVars.colors.background,
}),
{
'@media': {
[mq.tabletOrSmaller]: {
zIndex: 1,
},
},
},
]);

export const stickyButtons = sprinkles({
position: 'sticky',
bottom: 0,
background: skinVars.colors.background,
});
export const stickyButtons = style([
sprinkles({
position: 'sticky',
bottom: 0,
background: skinVars.colors.background,
}),
{
'@media': {
[mq.tabletOrSmaller]: {
zIndex: 1,
},
},
},
]);

export const bodyContent = style({
position: 'relative',
zIndex: 0,
'@media': {
[mq.desktopOrBigger]: {
overflowY: 'auto',
Expand Down
Loading