Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Sheet): avoid content from rendering on top of sticky title/buttons #1247

Merged
merged 7 commits into from
Sep 30, 2024
Merged

fix(Sheet): avoid content from rendering on top of sticky title/buttons #1247

merged 7 commits into from
Sep 30, 2024

Conversation

marcoskolodny
Copy link
Contributor

Issue: Link

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

Size stats

master this branch diff
Total JS 12.2 MB 12.2 MB +16 B
JS without icons 2.02 MB 2.02 MB +16 B
Lib overhead 68.3 kB 68.3 kB 0 B
Lib overhead (gzip) 16.6 kB 16.6 kB 0 B

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-kikhxynl8-flows-projects-65bb050e.vercel.app

Built with commit 74bb9f1.
This pull request is being automatically deployed with vercel-action

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

Screenshot tests report

✔️ All passing

pladaria
pladaria approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@pladaria pladaria left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not directly related with this PR but I found that when the screen is not large enough, the text zone becomes unreadable. In this case, the fixed footer shouldn't be fixed

image

can be reproduced here: https://mistica-jp8vz0d1w-flows-projects-65bb050e.vercel.app/?path=/story/components-modals-sheet--actions

yceballost
yceballost approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@yceballost yceballost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@marcoskolodny marcoskolodny added this pull request to the merge queue Sep 30, 2024
Merged via the queue into master with commit 21ce399 Sep 30, 2024
11 checks passed
@marcoskolodny marcoskolodny deleted the WEB-2016-sheet-body-zindex-fix branch September 30, 2024 09:56
tuentisre pushed a commit that referenced this pull request Oct 3, 2024
@semantic-release-bot
chore(release): 16.1.1 [skip ci]
260732c 
## [16.1.1](v16.1.0...v16.1.1) (2024-10-03)

### Bug Fixes

* **PhoneNumberField:** Revert lazy load of libphonenumber ([#1258](#1258)) ([3d18271](3d18271)), closes [#1244](#1244)
* **Sheet:** avoid content from rendering on top of sticky title/buttons ([#1247](#1247)) ([21ce399](21ce399))
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 16.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pladaria pladaria pladaria approved these changes

@atabel atabel atabel approved these changes

@yceballost yceballost yceballost approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marcoskolodny @tuentisre @pladaria @atabel @yceballost