-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More Erlang frameworks #938
Conversation
import setup_util | ||
|
||
def start(args, logfile, errfile): | ||
setup_util.replace_text("erlang-misultin/priv/app.config", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assumes package is in directory erlang-misultin
but lines 11-13 have a cwd of misultin
. Same issues with the other ones. Pick one of the directories to use and rename as appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
After fixing the issues that I commented about, I ran the test and it seemed to hang without any log updates - any ideas as to why that happened? |
Mochiweb is more priority, so better to check mochiweb.
Thanks. |
Do we really want Misultin? |
Misultin is not developed anymore, but it's still using in production and it's really interesting in performance aspect. |
@b0oh - If you rebase onto master, and update the |
@hamiltont thanks, done. |
Looks pretty close, but not quite there. Click for the build details, and scroll to the rows for erlang-* to see the output logs. A quick look shows these two errors:
and
|
Yes, I am already check log, we can ignore last warning, bacause rebar will create *.app files at compile section. About first error I am not sure how to avoid that, what version of erlang do you have? I suppose R14, if so how I can request new version? Locally I tested my code with R16 and R17. |
We are using this script to install erlang in our verification suite (which is ubuntu 12.04). I hate this script, because we don't know what version of erlang is installed (e.g. if you run this script on 12.04, you will probably get a different version than if you run this on 14.04). If you have the know-how, I would reallllly appreciate a pull request that changes this to either 1) download the erlang source code and build it or 2) just Additional Info: we are testing pull requestd on ubuntu 12.04 64bit, but we are running the benchmarks on ubuntu 14.04. So this scripting problem is quite relevant for erlang - you could successfully pass the verification, get merged into master, and then see round 10 come out with failures for all the |
I was check https://www.erlang-solutions.com/downloads/download-erlang-otp, and as they saying this file should be like that:
and this file like that:
Note I change esl-erlang to erlang. This should install R16B version. |
I'll update it in a bit. Could you tell me a one-line command to print out the erlang version? I will add taht in so the exact version is in the logs |
|
I'm working on fixing up the erlang install in my branch, this is blocked until that's working |
Ok, thanks. |
I am officially giving up on getting Erlang to work properly at the moment - perhaps someone is willing to merge in my branch and continue the work? No matter what I do I'm getting |
My only word of caution: Travis-CI comes with Erlang installed, so you sometimes get a |
All of the Erlang tests have their own My best guess (and we should get an Erlang expert to confirm this) is that we need to remove the |
@msmith-techempower this issue sounds related to #995 in that we could benefit from an isolated environment for each Erlang framework |
(in the long term...for now if we can at least get it to work that's a solution ;-) ) |
I don't know if it's related to #995 or not, but from what I can tell, but the analogy goes as follows:
If the jvm is globally installed, then it stands to reason that |
@msmith-techempower also keep #495 in mind as something that could potentially be closed concurrently if this problem is resolved
JVM is only globally installed because it's easier than a prefix install, but the same thought process works for beam too -- if it's easier than just do a global install at the moment ;-) |
Need to retest this since it's been over half-a-year and we may have addressed the |
@msmith-techempower nice to hear that |
I am working on a branch that simplifies the setup process quite a bit, but I'll pull this branch and see if I can't get it working. |
Pinging @waiteb3 as our resident Erlang expert to try and update these new frameworks to the new suite. |
05fbfd0
to
d5b976a
Compare
@ssmith-techempower We have fixed a lot of our issues with Erlang and Rebar, could you pull these changes, fix the merge conflicts, and test to see if we are ready to go here? |
sure, will give a look |
Looks like these haven't been updated since we moved away from using Python scripts to stop/start the frameworks. At least the following needs to be done:
You can look at |
ddbc264
to
c948188
Compare
@ssmith-techempower, @nbrady-techempower I lost my interest in benching erlang frameworks and as you used my code, I would like you to copy an |
I added three more Erlang frameworks: Mochiweb, Yaws and Misultin. Will be glad if someone can run benchmark, because I haven't possibility to run it. Thanks and have a nice day.