OIDC4VCI Draft 13 with vc format = jwt_vc_json, credential request is not correct

[ThierryThevenet]

when Draft 13 and vc format is jwt_vc_json or ldp_vc

wallet must send a credential request like

{
   "format": "jwt_vc_json",
   "credential_definition": {
      "type": [
         "VerifiableCredential",
         "UniversityDegreeCredential"
      ],
      "credentialSubject": {
         "given_name": {},
         "family_name": {},
         "degree": {}
      }
   },
   "proof": {
      "proof_type": "jwt",
      "jwt":"eyJraWQiOiJkaWQ6ZXhhbXBsZTplYmZlYjFmNzEyZWJjNmYxYzI3NmUxMmVjMjEva2V5cy8
      xIiwiYWxnIjoiRVMyNTYiLCJ0eXAiOiJKV1QifQ.eyJpc3MiOiJzNkJoZFJrcXQzIiwiYXVkIjoiaHR
      0cHM6Ly9zZXJ2ZXIuZXhhbXBsZS5jb20iLCJpYXQiOiIyMDE4LTA5LTE0VDIxOjE5OjEwWiIsIm5vbm
      NlIjoidFppZ25zbkZicCJ9.ewdkIkPV50iOeBUqMXCC_aZKPxgihac0aW9EkL1nOzM"
   }
}

In credential_definition object only type is required and credentialSubject is optional and limited to the claims without anything in side.

To make it simple, wallet provides in the request only type and remove credentialSubject as it is optional

example

{
   "format": "jwt_vc_json",
   "credential_definition": {
      "type": [
         "VerifiableCredential",
         "UniversityDegreeCredential"
      ]
   },
   "proof": {
      "proof_type": "jwt",
      "jwt":"eyJraWQiOiJkaWQ6ZXhhbXBsZTplYmZlYjFmNzEyZWJjNmYxYzI3NmUxMmVjMjEva2V5cy8
      xIiwiYWxnIjoiRVMyNTYiLCJ0eXAiOiJKV1QifQ.eyJpc3MiOiJzNkJoZFJrcXQzIiwiYXVkIjoiaHR
      0cHM6Ly9zZXJ2ZXIuZXhhbXBsZS5jb20iLCJpYXQiOiIyMDE4LTA5LTE0VDIxOjE5OjEwWiIsIm5vbm
      NlIjoidFppZ25zbkZicCJ9.ewdkIkPV50iOeBUqMXCC_aZKPxgihac0aW9EkL1nOzM"
   }
}

For info, I have seen the attribute order and display, etc in the credential request of the OIDC4VCI test 7

see below what is sent by wallet :

{
    "proof": {
        "proof_type": "jwt",
        "jwt": "eyJhbGciOiJFUzI1NiIsInR5cCI6Im9wZW5pZDR2Y2ktcHJvb2Yrand0Iiwia2lkIjoiZGlkOmp3azpleUpqY25ZaU9pSlFMVEkxTmlJc0ltdDBlU0k2SWtWRElpd2llQ0k2SW5kNGNWVkViVlo1YVdJeWJHNVRaUzFIVGtGd05qQmFTR2x3YWtFMllXSjJTVlJ6U0VweVpWRk1OR3NpTENKNUlqb2lkMjlQWTFGWGVXVnJPRGhFVHpSeVltTTRiMUpNUld4dE56VkJhVlpWZWtZd2MzZHJkRU5xTW0xSVRTSjkjMCJ9.eyJpc3MiOiJkaWQ6andrOmV5SmpjbllpT2lKUUxUSTFOaUlzSW10MGVTSTZJa1ZESWl3aWVDSTZJbmQ0Y1ZWRWJWWjVhV0l5Ykc1VFpTMUhUa0Z3TmpCYVNHbHdha0UyWVdKMlNWUnpTRXB5WlZGTU5Hc2lMQ0o1SWpvaWQyOVBZMUZYZVdWck9EaEVUelJ5WW1NNGIxSk1SV3h0TnpWQmFWWlZla1l3YzNkcmRFTnFNbTFJVFNKOSIsImlhdCI6MTcyMTI0NjA4MywiYXVkIjoiaHR0cDovLzE5Mi4xNjguMC4yMDozMDAwL2lzc3Vlci9yYWFteGVwcWV4Iiwibm9uY2UiOiI3YThmNjZlMC00NDc2LTExZWYtYWE4MS0xN2Y2ODNiZmZlODEifQ.mvtV5t42y57g4XIydAA3U6MWBah3_JPepi-WQSIfaTCrx0-abXb7_80yffq4hlwk75nRstT8Ste5dn9wTMGgeQ"
    },
    "format": "jwt_vc_json",
    "credential_definition": {
        "credentialSubject": {
            "dateIssued": {
                "display": [
                    {
                        "locale": "en-US",
                        "name": "Issuance date"
                    },
                    {
                        "locale": "fr-FR",
                        "name": "D\u00e9livr\u00e9 le"
                    }
                ],
                "mandatory": true
            },
            "dateOfBirth": {
                "display": [
                    {
                        "locale": "en-US",
                        "name": "Date of birth"
                    },
                    {
                        "locale": "fr-FR",
                        "name": "N\u00e9(e) le"
                    }
                ],
                "mandatory": true
            },
            "email": {
                "display": [
                    {
                        "locale": "en-US",
                        "name": "Email"
                    },
                    {
                        "locale": "fr-FR",
                        "name": "Email"
                    }
                ],
                "mandatory": true
            },
            "familyName": {
                "display": [
                    {
                        "locale": "en-US",
                        "name": "Family name"
                    },
                    {
                        "locale": "fr-FR",
                        "name": "Nom"
                    }
                ],
                "mandatory": true
            },
            "firstName": {
                "display": [
                    {
                        "locale": "en-US",
                        "name": "First name"
                    },
                    {
                        "locale": "fr-FR",
                        "name": "Pr\u00e9nom(s)"
                    }
                ],
                "mandatory": true
            },
            "gender": {
                "display": [
                    {
                        "locale": "en-US",
                        "name": "Gender"
                    },
                    {
                        "locale": "fr-FR",
                        "name": "Sexe"
                    }
                ],
                "mandatory": true
            },
            "issuing_country": {
                "display": [
                    {
                        "locale": "en-US",
                        "name": "Issuing country"
                    },
                    {
                        "locale": "fr-FR",
                        "name": "D\u00e9livr\u00e9 par"
                    }
                ],
                "mandatory": true
            },
            "phone_number": {
                "display": [
                    {
                        "locale": "en-US",
                        "name": "Phone number"
                    },
                    {
                        "locale": "fr-FR",
                        "name": "T\u00e9l\u00e9phone"
                    }
                ],
                "mandatory": true
            }
        },
        "order": [
            "firstName",
            "familyName",
            "dateOfBirth",
            "gender",
            "dateIssued",
            "issuing_country",
            "email",
            "phone_number"
        ],
        "type": [
            "VerifiableCredential",
            "VerifiableId"
        ]
    }
}