Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto account VC to be displayed depending on the selected crypto account #2680

Open
ThierryThevenet opened this issue May 24, 2024 · 14 comments
Assignees
Labels

Comments

@ThierryThevenet
Copy link
Member

No description provided.

@ThierryThevenet ThierryThevenet changed the title crypto account VC to be displayed depending on the crypto account crypto account VC to be displayed depending on the selected crypto account May 24, 2024
@jtdemer
Copy link

jtdemer commented Jun 20, 2024

Are there any news regarding that issue? @ThierryThevenet

@ThierryThevenet
Copy link
Member Author

We can schedule it for next week if needed

@jtdemer
Copy link

jtdemer commented Jun 24, 2024

That would be realy great and helpfull.

@ThierryThevenet
Copy link
Member Author

@jtdemer Hello, it looks ok for us in Altme 2.7.0 ?
It means that if we have 2 tezos accounts with 2 accounts VC, only the one of the selected account is displayed
Can you confirm ?

@jtdemer
Copy link

jtdemer commented Jun 25, 2024

@ThierryThevenet Hi, on android the latest for me availible version of Altme is 2.6.0. from the 31.05.2024.

So I can't check it with version 2.7.0, but I can remember while testing it with daniel @dansan566 , he had the same issues with ios and version 2.7.0.

Do you know when altme 2.7.0 is availible on android?

@ThierryThevenet
Copy link
Member Author

From our side it is also ok on 2.6.0.
Can you send us a video with the issue ?

@dansan566
Copy link

dansan566 commented Jul 24, 2024

@ThierryThevenet can you please check if this feature also works for "My other cards". I'm currently using Altme Version 2.9.10 (479):

The account ownership card is displayed correctly and only once for each account (notice the change of address). What I would have expected is that the grey card (member credential) is only visible to account "New Company Inc." and the green card (user credential) is only visible for account "User of company".

IMG_7750

IMG_7749

@ThierryThevenet
Copy link
Member Author

Can you send me the 2 vc ?

@dansan566
Copy link

@ThierryThevenet
Copy link
Member Author

@bibash28

hawkbee1 added a commit that referenced this issue Aug 15, 2024
* fix: Update account name instantly #2667

* linter update

* feat: Add green color for card valid status #2764

* color adjustment

* fix: Avoid double scan to get and present #2668

* fix: Fetch uri for image but not working and indication of deleted message #2771

* feat: Add all type of VCs #2779

* feat: Support all types presentaton wth VCFormat auto #2779

* feat: Update credential request for draft 13 - jwt_vc_json and ldp_vc #2796

* version update: 2.9.8+477

* Revert "version update: 2.9.8+477"

This reverts commit 6e8265c.

* refactor: Update oidc4vc test

* refactor: Try to display image #2771

* fix: Fix image and add photo viewer #2771

* refactor: Optimise code to load image smoothly side by side #2771

* feat: Display advanced security option in enterprise #2584

* feat: Update error responses #2573

* refactor: Remove long error message for now #2573

* refactor: Display advanced security options #2584

* refactor: Bug fix and optimise code

* some update and package update

* feat: Some bug fix

* feat: Add some etherlink functionlities #2820

* version update: 2.10.4+486

* feat: Add empty etherlink when no tokens are available

* version update : 2.10.5+487

* feat: Add etherlink balance and transfer

* version update: 2.10.6+488

* refactor: Copy clipboard data correctly #2830

* refactor: Copy clipboard data correctly #2830

* refactor: Create crypto account VC for etherlink #2833

* feat: Set timeout of 10seconds for statulist http get #2824

* feat: Enable advanced settings for non-enterprise profile #2828

* refactor: Correct the backend provider url #2818

* feat: Display some vc based on crypto account did issuer #2680

* version update: 2.10.7+489

* fix: Advanced security option #2828

* feat: Fix wallet configuration failing issue #2835

* fix: Show crypto account for respective wallet address only #2833

* version update:  2.10.8+490

---------

Co-authored-by: Bibash Shrestha <bibashshrestha@gmail.com>
hawkbee1 added a commit that referenced this issue Aug 21, 2024
* fix: Update account name instantly #2667

* linter update

* feat: Add green color for card valid status #2764

* color adjustment

* fix: Avoid double scan to get and present #2668

* fix: Fetch uri for image but not working and indication of deleted message #2771

* feat: Add all type of VCs #2779

* feat: Support all types presentaton wth VCFormat auto #2779

* feat: Update credential request for draft 13 - jwt_vc_json and ldp_vc #2796

* version update: 2.9.8+477

* Revert "version update: 2.9.8+477"

This reverts commit 6e8265c.

* refactor: Update oidc4vc test

* refactor: Try to display image #2771

* fix: Fix image and add photo viewer #2771

* refactor: Optimise code to load image smoothly side by side #2771

* feat: Display advanced security option in enterprise #2584

* feat: Update error responses #2573

* refactor: Remove long error message for now #2573

* refactor: Display advanced security options #2584

* refactor: Bug fix and optimise code

* some update and package update

* feat: Some bug fix

* feat: Add some etherlink functionlities #2820

* version update: 2.10.4+486

* feat: Add empty etherlink when no tokens are available

* version update : 2.10.5+487

* feat: Add etherlink balance and transfer

* version update: 2.10.6+488

* refactor: Copy clipboard data correctly #2830

* refactor: Copy clipboard data correctly #2830

* refactor: Create crypto account VC for etherlink #2833

* feat: Set timeout of 10seconds for statulist http get #2824

* feat: Enable advanced settings for non-enterprise profile #2828

* refactor: Correct the backend provider url #2818

* feat: Display some vc based on crypto account did issuer #2680

* version update: 2.10.7+489

* fix: Advanced security option #2828

* feat: Fix wallet configuration failing issue #2835

* fix: Show crypto account for respective wallet address only #2833

* version update:  2.10.8+490

* fix: Solve deeplink issue #2836

* feat: Fix button of dialog #2816

* version update: 2.10.9+491

* feat: Change icon color for Add account section #2842

* feat: Improve screen design #2815

* feat: Dialog bug fix

* feat: Add cancel button in sd-jwt selection screen #2843

* feat: Hide disabled button when limited disclosure is required #2844

* feat: Change the issuer call for vertifiable ID for profile DIIP V3.0 in discover #2837

* version update: 2.10.11+493

* refactor: Remove unnecessary codes

* feat: Add empty tokens for etherlink #2840

* feat: Add empty tokens for tezos #2840

* feat: Add empty tokens for tezos #2840

* feat: Add empty tokens for evms #2840

* display nested json on one level - no display

---------

Co-authored-by: Bibash Shrestha <bibashshrestha@gmail.com>
@hawkbee1
Copy link
Collaborator

@hawkbee1 to test.

@dansan566
Copy link

dansan566 commented Oct 30, 2024

@ThierryThevenet why was this issue closed?

image

@ThierryThevenet
Copy link
Member Author

Can we close this ticket ? @hawkbee1

@hawkbee1
Copy link
Collaborator

hawkbee1 commented Jan 6, 2025

I think so
@dansan566 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants