Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(client): some migration step for react-router@v6 #3151

Merged
merged 15 commits into from
May 30, 2024
Merged

refactor(client): some migration step for react-router@v6 #3151

merged 15 commits into from
May 30, 2024

Conversation

leafty
Copy link
Member

@leafty leafty commented May 28, 2024 •
edited
Loading

Setup CompatRoute for some top-level routes.

Setup CompatRoute for:

  • /search
  • /inactive-kg-projects
  • /projects
  • /projects/starred
  • /projects/all
  • /projects/new

See:

/deploy renku=master

@leafty
refactor(client): some migration step for react-router@v6
64c3001 
Setup CompatRoute for some top-level routes.

Setup CompatRoute for:
* `/search`

See:
* #3028
* #3041
@leafty leafty temporarily deployed to renku-ci-ui-3151 May 28, 2024 12:38 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3151.dev.renku.ch

@leafty leafty temporarily deployed to renku-ci-ui-3151 May 28, 2024 12:52 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3151 May 28, 2024 14:08 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3151 May 28, 2024 14:29 — with GitHub Actions Inactive
@leafty leafty marked this pull request as ready for review May 29, 2024 11:06
@leafty leafty requested a review from a team as a code owner May 29, 2024 11:06
@leafty leafty temporarily deployed to renku-ci-ui-3151 May 29, 2024 11:06 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3151 May 29, 2024 11:37 — with GitHub Actions Inactive
@lorenzo-cavazzi lorenzo-cavazzi self-assigned this May 29, 2024
lorenzo-cavazzi
lorenzo-cavazzi requested changes May 29, 2024
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Just need to drop an unused variable

client/src/features/inactiveKgProjects/InactiveKgProjects.tsx Outdated Show resolved Hide resolved
client/src/project/new/ProjectNew.test.jsx Outdated Show resolved Hide resolved
@leafty @lorenzo-cavazzi
Update client/src/features/inactiveKgProjects/InactiveKgProjects.tsx
ad76eaf 
Co-authored-by: Lorenzo Cavazzi <43481553+lorenzo-cavazzi@users.noreply.github.com>
@leafty leafty temporarily deployed to renku-ci-ui-3151 May 29, 2024 14:08 — with GitHub Actions Inactive
@leafty leafty requested a review from lorenzo-cavazzi May 29, 2024 14:08
@leafty leafty temporarily deployed to renku-ci-ui-3151 May 29, 2024 17:52 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3151 May 30, 2024 06:51 — with GitHub Actions Inactive
@leafty leafty force-pushed the leafty/react-router-migration-3 branch from 1626cd0 to 7016439 Compare May 30, 2024 07:17
@leafty leafty temporarily deployed to renku-ci-ui-3151 May 30, 2024 07:18 — with GitHub Actions Inactive
@leafty leafty merged commit 4a1f2ac into main May 30, 2024
18 checks passed
@leafty leafty deleted the leafty/react-router-migration-3 branch May 30, 2024 11:29
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

@leafty leafty mentioned this pull request Jan 3, 2025
Merged
leafty added a commit that referenced this pull request Jan 6, 2025
@leafty
refactor(client): some migration step for react-router@v6 (#3466)
bf3ec8b 
Setup CompatRoute for dataset routes.

* `/projects/<project>/datasets/*`

See:
* #3028
* #3041
* #3151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenzo-cavazzi lorenzo-cavazzi lorenzo-cavazzi approved these changes

Assignees

@lorenzo-cavazzi lorenzo-cavazzi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leafty @RenkuBot @lorenzo-cavazzi