Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(client): some migration step for react-router@v6 #3041

Merged
merged 3 commits into from
Feb 15, 2024
Merged

refactor(client): some migration step for react-router@v6 #3041

merged 3 commits into from
Feb 15, 2024

Conversation

leafty
Copy link
Member

@leafty leafty commented Feb 14, 2024 •
edited
Loading

Migrate routing on /help pages and setup CompatRoute for some top-level routes.

See:

/deploy renku=release-0.48.x

@leafty leafty temporarily deployed to renku-ci-ui-3041 February 15, 2024 08:00 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3041.dev.renku.ch

@leafty leafty marked this pull request as ready for review February 15, 2024 08:14
@leafty leafty requested a review from a team as a code owner February 15, 2024 08:14
@leafty leafty temporarily deployed to renku-ci-ui-3041 February 15, 2024 08:14 — with GitHub Actions Inactive
lorenzo-cavazzi
lorenzo-cavazzi approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 🚀

@leafty leafty temporarily deployed to renku-ci-ui-3041 February 15, 2024 08:26 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3041 February 15, 2024 10:24 — with GitHub Actions Inactive
@leafty leafty merged commit 5e1dd23 into main Feb 15, 2024
17 checks passed
@leafty leafty deleted the leafty/react-router-migration-2 branch February 15, 2024 11:50
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

leafty added a commit that referenced this pull request May 28, 2024
@leafty
refactor(client): some migration step for react-router@v6
64c3001 
Setup CompatRoute for some top-level routes.

Setup CompatRoute for:
* `/search`

See:
* #3028
* #3041
@leafty leafty mentioned this pull request May 28, 2024
Merged
leafty added a commit that referenced this pull request May 30, 2024
@leafty
refactor(client): some migration step for react-router@v6 (#3151)
4a1f2ac 
Setup CompatRoute for some top-level routes.

Setup CompatRoute for:
* `/search`
* `/inactive-kg-projects`
* `/projects`
* `/projects/starred`
* `/projects/all`
* `/projects/new`

See also:
* #3028
* #3041
@leafty leafty mentioned this pull request Jan 3, 2025
Merged
leafty added a commit that referenced this pull request Jan 6, 2025
@leafty
refactor(client): some migration step for react-router@v6 (#3466)
bf3ec8b 
Setup CompatRoute for dataset routes.

* `/projects/<project>/datasets/*`

See:
* #3028
* #3041
* #3151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenzo-cavazzi lorenzo-cavazzi lorenzo-cavazzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leafty @RenkuBot @lorenzo-cavazzi