fix: Mount /dev/shm to the correct container. #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b85d1e1 to
73d7a0f
Compare
|
You can access the deployment of this PR at https://renku-ci-nb-1984.dev.renku.ch |
olevski
requested changes
Sep 18, 2024
Thanks, I've included your change. |
I absolutely agree. The new version of amalthea does not have patches like this at all. So when we retire the old version this code will just be thrown out. |
Currently container #1 is `oauth-proxy` while JupyterServer, is #0. Additionally use half of the memory requested by the pod instead of half of the storage. Since we rely on memory there is no need to tie the increased /dev/shm to requesting storage in the session. NOTE: This system of patching the manifest is very brittle and the bug being fixed by this commit might appear again as soon as the containers sorting changes. We should think about a different way of interacting with the manifests of the user-sessions.
08bab41 to
24740fc
Compare
olevski
approved these changes
Sep 18, 2024
olevski
pushed a commit
to SwissDataScienceCenter/renku-data-services
that referenced
this pull request
Dec 10, 2024
olevski
added a commit
to SwissDataScienceCenter/renku-data-services
that referenced
this pull request
Dec 10, 2024
Migrating SwissDataScienceCenter/renku-notebooks#1984 Co-authored-by: Alessandro Degano <alessandro.degano@epfl.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently container #1 is
oauth-proxywhile JupyterServer, is #0.Additionally use half of the memory requested by the pod instead of half of the storage.
Since we rely on memory there is no need to tie the increased /dev/shm to requesting storage in the session.
NOTE: This system of patching the manifest is very brittle and the bug being fixed by this commit might appear again as soon as the containers sorting changes. We should think about a different way of interacting with the manifests of the user-sessions.
/deploy renku=leafty/fix-renku-jupyterserver