Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use dns-safe server names #1

Closed
rokroskar opened this issue May 30, 2018 · 1 comment · Fixed by #7
Closed

use dns-safe server names #1

rokroskar opened this issue May 30, 2018 · 1 comment · Fixed by #7
Labels
bug Something isn't working

Comments

@rokroskar
Copy link
Member

Still failing on usernames with non alpha-numeric characters:

{"reason":"FieldValueInvalid","message":"Invalid value: \"renku-jupyter-rok-2erosk-rok_2erosk-proj-85a5229\": a DNS-1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')"

The username was rok.roskar. This issue is continued from SwissDataScienceCenter/renku#252.
@rokroskar rokroskar added the bug Something isn't working label May 30, 2018
@rokroskar rokroskar mentioned this issue May 31, 2018
Merged
@rokroskar
Copy link
Member Author

closed via #7

@olevski olevski mentioned this issue Dec 14, 2022
Open
aledegano added a commit that referenced this issue Sep 18, 2024
@aledegano
fix: Mount /dev/shm to the correct container.
b85d1e1 
Currently container #1 is `oauth-proxy` while JupyterServer,
is #0.

Additionally use half of the memory requested by the pod
instead of half of the storage.

Since we rely on memory there is no need to tie the increased
/dev/shm to requesting storage in the session.

NOTE: This system of patching the manifest is very brittle and
the bug being fixed by this commit might appear again as soon
as the containers sorting changes. We should think about a different
way of interacting with the manifests of the user-sessions.
@aledegano aledegano mentioned this issue Sep 18, 2024
Merged
aledegano added a commit that referenced this issue Sep 18, 2024
@aledegano
fix: Mount /dev/shm to the correct container.
73d7a0f 
Currently container #1 is `oauth-proxy` while JupyterServer,
is #0.

Additionally use half of the memory requested by the pod
instead of half of the storage.

Since we rely on memory there is no need to tie the increased
/dev/shm to requesting storage in the session.

NOTE: This system of patching the manifest is very brittle and
the bug being fixed by this commit might appear again as soon
as the containers sorting changes. We should think about a different
way of interacting with the manifests of the user-sessions.
aledegano added a commit that referenced this issue Sep 18, 2024
@aledegano
fix: Mount /dev/shm to the correct container.
24740fc 
Currently container #1 is `oauth-proxy` while JupyterServer,
is #0.

Additionally use half of the memory requested by the pod
instead of half of the storage.

Since we rely on memory there is no need to tie the increased
/dev/shm to requesting storage in the session.

NOTE: This system of patching the manifest is very brittle and
the bug being fixed by this commit might appear again as soon
as the containers sorting changes. We should think about a different
way of interacting with the manifests of the user-sessions.
aledegano added a commit that referenced this issue Sep 19, 2024
@aledegano
fix: Mount /dev/shm to the correct container. (#1984)
8b47163 
* fix: Mount /dev/shm to the correct container.

Currently container #1 is `oauth-proxy` while JupyterServer,
is #0.

Additionally use half of the memory requested by the pod
instead of half of the storage.

Since we rely on memory there is no need to tie the increased
/dev/shm to requesting storage in the session.

NOTE: This system of patching the manifest is very brittle and
the bug being fixed by this commit might appear again as soon
as the containers sorting changes. We should think about a different
way of interacting with the manifests of the user-sessions.

* chore: update renku-actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

app: fix pod name escape char SwissDataScienceCenter/renku-notebooks
1 participant
@rokroskar