fix: remove unused field from secrets storage request #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olevski
approved these changes
Jun 21, 2024
olevski
pushed a commit
to SwissDataScienceCenter/renku-data-services
that referenced
this pull request
Dec 10, 2024
olevski
pushed a commit
to SwissDataScienceCenter/renku-data-services
that referenced
this pull request
Dec 10, 2024
olevski
added a commit
to SwissDataScienceCenter/renku-data-services
that referenced
this pull request
Dec 10, 2024
Migrating SwissDataScienceCenter/renku-notebooks#1901 Co-authored-by: Ralf Grubenmann <ralf.grubenmann@sdsc.ethz.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relevant change is line 484
we had this field in the apispec but in secrets-storage it's hardcoded to true, which makes sense as if you specify an owner for a secret, that thing should control the secret. secrets storage itself doesn't do any lifecycle management.