Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused field from secrets storage request #566

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

olevski
Copy link
Member

@olevski olevski commented Dec 10, 2024

@olevski olevski requested a review from a team as a code owner December 10, 2024 08:09
@coveralls
Copy link

coveralls commented Dec 10, 2024

Pull Request Test Coverage Report for Build 12253755991

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 85.725%

Files with Coverage Reduction New Missed Lines %
components/renku_data_services/notebooks/core.py 1 60.65%
Totals Coverage Status
Change from base Build 12253732488: 0.01%
Covered Lines: 14521
Relevant Lines: 16939

💛 - Coveralls

@olevski olevski enabled auto-merge (squash) December 10, 2024 10:04
@olevski olevski merged commit 95ca49e into main Dec 10, 2024
12 checks passed
@olevski olevski deleted the notebooks-catchup-2 branch December 10, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants