Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Cont. More query tests #47

Merged
merged 4 commits into from
Sep 22, 2022
Merged

Cont. More query tests #47

merged 4 commits into from
Sep 22, 2022

Conversation

Du-z
Copy link
Collaborator

@Du-z Du-z commented Sep 22, 2022

make use of a xUnit Collection Fixture to stop and start the test database.

it now starts the DB in memory mode as we do not want to keep the data after the tests have completed.

Also added some more test, some are failing

Copy link
Collaborator

@ProphetLamb ProphetLamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Thank you for the test cases:3
Using a Testfixture is a much more beautiful solution than parsing command output. I am closing my draft in favor of yours.
Cheers!

@ProphetLamb ProphetLamb merged commit fb6d49c into Surreal-Net:master Sep 22, 2022
@ProphetLamb
Copy link
Collaborator

@all-contributors add @Du-z for bug ideas

@allcontributors
Copy link

@ProphetLamb

I've put up a pull request to add @Du-z! 🎉

@Du-z
Copy link
Collaborator Author

Du-z commented Sep 22, 2022

@ProphetLamb

Left on my list for tests are:

  • Multiple result set handing
  • Converters testing (Working on this now)
  • Add a few more types to the roundtrip test
    • DateTimeOffset
    • DateOnly
    • TimeOnly
    • Arrays
    • Objects
  • DB Error Responses

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants