This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
Implement selective process kill #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It works with a few tweaks, but I also get the following message after a test run.
Which inspired me to tweak your approach slightly to make use of xUnit Collection Fixture. I feel far more comfortable with this approach as it can only ever kill its own DB process after running all of its tests. See #47 for the PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Du-z Here I implement the selective killing of SurrealDB. This works on Linux, the Windows impl is yoinked from stackoverflow. Could you verify whether it works fo you?