Use detokenization amount from tx response #934
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Context
Similar to unbondings, detokenization ICAs have the potential to return slightly less tokens than were specified in the tx due to rounding imprecision in the SDK (see #933 for more context). This can create a small difference in stride's internal record keeping (on the order of < 10uatom).
However, the number of tokens that winds up being detokenized is part of the tx response, so we can just use that value instead, which will prevent the rounding imprecision from being reflected in record keeping.
Brief Changelog
RedeemTokensForShares
messageAuthor's Checklist
I have...
If skipped any of the tests above, explain.
Integration Tests
Documentation and Release Note
Unreleased
section inCHANGELOG.md
?How is the feature or change documented?
XXX
x/<module>/spec/
)